Re: [PATCH] pathspec.c: Fix some sparse warnings

2012-10-28 Thread Jeff King
On Sun, Oct 28, 2012 at 09:09:19PM +, Ramsay Jones wrote: > I asked Adam to squash this patch into his 'as/check-ignore' branch > when he next re-rolled the branch. However, it appears that you > resubmitted that branch instead ... :-D > > I don't know if this branch is ready to progress to n

Re: [PATCH] pathspec.c: Fix some sparse warnings

2012-10-28 Thread Adam Spiers
On Sun, Oct 28, 2012 at 9:09 PM, Ramsay Jones wrote: > Sparse issues a warning for all six external symbols defined in this > file. In order to suppress the warnings, we include the 'pathspec.h' > header file, which contains the relevant extern declarations for these > symbols. > > Signed-off-by:

[PATCH] pathspec.c: Fix some sparse warnings

2012-10-28 Thread Ramsay Jones
Sparse issues a warning for all six external symbols defined in this file. In order to suppress the warnings, we include the 'pathspec.h' header file, which contains the relevant extern declarations for these symbols. Signed-off-by: Ramsay Jones --- Hi Nguyen, I asked Adam to squash this patch

Re: [PATCH] pathspec.c: Fix some sparse warnings

2012-09-25 Thread Adam Spiers
On Tue, Sep 25, 2012 at 6:15 PM, Ramsay Jones wrote: > > Sparse issues a warning for all six external symbols defined in this > file. In order to suppress the warnings, we include the 'pathspec.h' > header file, which contains the relevant extern declarations for these > symbols. > > Signed-off-by

[PATCH] pathspec.c: Fix some sparse warnings

2012-09-25 Thread Ramsay Jones
Sparse issues a warning for all six external symbols defined in this file. In order to suppress the warnings, we include the 'pathspec.h' header file, which contains the relevant extern declarations for these symbols. Signed-off-by: Ramsay Jones --- Hi Adam, When you re-roll your 'as/check-ign