Re: [PATCH] pathspec: stop --*-pathspecs impact on internal parse_pathspec() uses

2013-10-25 Thread Jeff King
On Sat, Oct 26, 2013 at 09:09:20AM +0700, Nguyen Thai Ngoc Duy wrote: > Jeff, how about this? > > It's similar to your last suggestion (i.e. relaxing the magic mask > about literal magic). In addition, it forces literal magic > unconditionally in this case, which I think is the right thing

[PATCH] pathspec: stop --*-pathspecs impact on internal parse_pathspec() uses

2013-10-25 Thread Nguyễn Thái Ngọc Duy
Normally parse_pathspec() is used on command line arguments where it can do fancy thing like parsing magic on each argument or adding magic for all pathspecs based on --*-pathspecs options. There's another use of parse_pathspec(), where pathspec is needed, but the input is known to be pure paths.

[PATCH] pathspec: stop --*-pathspecs impact on internal parse_pathspec() uses

2013-10-25 Thread Nguyễn Thái Ngọc Duy
Normally parse_pathspec() is used on command line arguments where it can do fancy thing like parsing magic on each argument or adding magic for all pathspecs based on --*-pathspecs options. There's another use of parse_pathspec(), where pathspec is needed, but the input is known to be pure paths.