Re: [PATCH] pathspec: give better message for submodule related pathspec error

2017-01-03 Thread Jeff King
On Tue, Jan 03, 2017 at 10:15:38AM -0800, Stefan Beller wrote: > > I take that the new "BUG" thing tells the Git developers that no > > sane codepath should throw an pathspec_item that satisfies the > > condition of the if() statement for non-submodules? > > If we want to keep the semantics of th

Re: [PATCH] pathspec: give better message for submodule related pathspec error

2017-01-03 Thread Stefan Beller
On Sat, Dec 31, 2016 at 5:11 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Every once in a while someone complains to the mailing list to have >> run into this weird assertion[1]. >> >> The usual response from the mailing list is link to old discussions[2], >> and acknowledging the probl

Re: [PATCH] pathspec: give better message for submodule related pathspec error

2016-12-31 Thread Junio C Hamano
Stefan Beller writes: > Every once in a while someone complains to the mailing list to have > run into this weird assertion[1]. > > The usual response from the mailing list is link to old discussions[2], > and acknowledging the problem stating it is known. > > For now just improve the user visibl

[PATCH] pathspec: give better message for submodule related pathspec error

2016-12-29 Thread Stefan Beller
Every once in a while someone complains to the mailing list to have run into this weird assertion[1]. The usual response from the mailing list is link to old discussions[2], and acknowledging the problem stating it is known. For now just improve the user visible error message. [1] https://www.go

Re: [PATCH] pathspec: give better message for submodule related pathspec error

2016-12-28 Thread Brandon Williams
On 12/27, Stefan Beller wrote: > Every once in a while someone complains to the mailing list to have > run into this weird assertion[1]. > > The usual response from the mailing list is link to old discussions[2], > and acknowledging the problem stating it is known. > > For now just improve the us

Re: [PATCH] pathspec: give better message for submodule related pathspec error

2016-12-27 Thread Jeff King
On Tue, Dec 27, 2016 at 04:05:59PM -0800, Stefan Beller wrote: > Every once in a while someone complains to the mailing list to have > run into this weird assertion[1]. If people are running into it, it definitely should not be an assert, nor a die("BUG"). It should be a regular die(), which your

[PATCH] pathspec: give better message for submodule related pathspec error

2016-12-27 Thread Stefan Beller
Every once in a while someone complains to the mailing list to have run into this weird assertion[1]. The usual response from the mailing list is link to old discussions[2], and acknowledging the problem stating it is known. For now just improve the user visible error message. [1] https://www.go