Re: [PATCH] path: use xmalloc in add_to_trie

2017-10-24 Thread Jeff King
On Tue, Oct 24, 2017 at 09:13:28AM -0700, Stefan Beller wrote: > On Tue, Oct 24, 2017 at 8:15 AM, Andrey Okoshkin > wrote: > > Add usage of xmalloc() instead of malloc() in add_to_trie() as xmalloc wraps > > and checks memory allocation result. > > > > Signed-off-by: Andrey Okoshkin > > --- > >

Re: [PATCH] path: use xmalloc in add_to_trie

2017-10-24 Thread Stefan Beller
On Tue, Oct 24, 2017 at 8:15 AM, Andrey Okoshkin wrote: > Add usage of xmalloc() instead of malloc() in add_to_trie() as xmalloc wraps > and checks memory allocation result. > > Signed-off-by: Andrey Okoshkin > --- > Hello, > I'm not sure but it looks like there is a missing check of the malloc r

[PATCH] path: use xmalloc in add_to_trie

2017-10-24 Thread Andrey Okoshkin
Add usage of xmalloc() instead of malloc() in add_to_trie() as xmalloc wraps and checks memory allocation result. Signed-off-by: Andrey Okoshkin --- Hello, I'm not sure but it looks like there is a missing check of the malloc result. memcpy() may crash with SIGSEGV due to the memory allocation fa