Re: [PATCH] parse-options: fix the description of defval

Ivan Ukhov writes: > Hello Junio, > > > Yes, actually my intention to fix that comment was solely based on its > content. I saw that the elements in the first set, {BIT,SET_INT}, did > not match the elements in the second, {mask,integer,pointer}. Then I > found that commit removing OPT_SET_PTR, a

Re: [PATCH] parse-options: fix the description of defval

Hello Junio, Yes, actually my intention to fix that comment was solely based on its content. I saw that the elements in the first set, {BIT,SET_INT}, did not match the elements in the second, {mask,integer,pointer}. Then I found that commit removing OPT_SET_PTR, and “pointer” seemed to be a le

Re: [PATCH] parse-options: fix the description of defval

Paul Tan writes: > On Sun, Mar 29, 2015 at 4:32 PM, Ivan Ukhov wrote: >> Since the deletion of OPT_SET_PTR, defval can no longer contain a pointer. >> > > Actually, it can contain a pointer for OPTION_CMDMODE, OPTION_STRING > and OPTION_FILENAME. Since we are on the topic of updating the > docum

Re: [PATCH] parse-options: fix the description of defval

Hello Paul, Yes, you are right. Thank you for the clarification! Regards, Ivan > On Mar 29, 2015, at 3:27 PM, Paul Tan wrote: > > Hi, > > On Sun, Mar 29, 2015 at 5:28 PM, Ivan Ukhov wrote: >> I have checked the definitions of the three macros you mentioned, and it >> seems that none of th

Re: [PATCH] parse-options: fix the description of defval

Hi, On Sun, Mar 29, 2015 at 5:28 PM, Ivan Ukhov wrote: > I have checked the definitions of the three macros you mentioned, and it > seems that none of them uses defval to store pointers. OPTION_CMDMODE stores > chars and integers. OPTION_STRING does not use defval at all (pointers go in > a di

Re: [PATCH] parse-options: fix the description of defval

Hello Paul, > On Mar 29, 2015, at 11:08 AM, Paul Tan wrote: > > Actually, it can contain a pointer for OPTION_CMDMODE, OPTION_STRING > and OPTION_FILENAME. I have checked the definitions of the three macros you mentioned, and it seems that none of them uses defval to store pointers. OPTION_CM

Re: [PATCH] parse-options: fix the description of defval

Hi, On Sun, Mar 29, 2015 at 4:32 PM, Ivan Ukhov wrote: > Since the deletion of OPT_SET_PTR, defval can no longer contain a pointer. > Actually, it can contain a pointer for OPTION_CMDMODE, OPTION_STRING and OPTION_FILENAME. Since we are on the topic of updating the documentation, I think it woul

[PATCH] parse-options: fix the description of defval

Since the deletion of OPT_SET_PTR, defval can no longer contain a pointer. Signed-off-by: Ivan Ukhov --- parse-options.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/parse-options.h b/parse-options.h index 7940bc7..c71e9da 100644 --- a/parse-options.h +++ b/parse-options