Re: [PATCH] packfile: free packed_git memory when closing object store

2019-08-26 Thread Mike Hommey
On Mon, Aug 26, 2019 at 11:06:29AM -0700, Junio C Hamano wrote: > Mike Hommey writes: > > > Signed-off-by: Mike Hommey > > --- > > packfile.c | 11 +++ > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > Note, I'm not sure this is the right place to do it. > > I do not think th

Re: [PATCH] packfile: free packed_git memory when closing object store

2019-08-26 Thread Junio C Hamano
Mike Hommey writes: > Signed-off-by: Mike Hommey > --- > packfile.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > Note, I'm not sure this is the right place to do it. I do not think this patch is complete, given that o->packed_git still has a non-NULL pointer. IIRC,

[PATCH] packfile: free packed_git memory when closing object store

2019-08-25 Thread Mike Hommey
Signed-off-by: Mike Hommey --- packfile.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) Note, I'm not sure this is the right place to do it. diff --git a/packfile.c b/packfile.c index fc43a6c52c..b0cb84adda 100644 --- a/packfile.c +++ b/packfile.c @@ -339,13 +339,16 @@ void