Re: [PATCH] pack-bitmap: Don't perform unaligned memory access

2017-06-26 Thread Jonathan Nieder
James Clarke wrote: > The preceding bitmap entries have a 1-byte XOR-offset and 1-byte flags, > so their size is not a multiple of 4. Thus the name-hash cache is only > guaranteed to be 2-byte aligned and so we must use get_be32 rather than > indexing the array directly. > > Signed-off-by: James C

Re: [PATCH] pack-bitmap: Don't perform unaligned memory access

2017-06-26 Thread Junio C Hamano
James Clarke writes: > The preceding bitmap entries have a 1-byte XOR-offset and 1-byte flags, > so their size is not a multiple of 4. Thus the name-hash cache is only > guaranteed to be 2-byte aligned and so we must use get_be32 rather than > indexing the array directly. > > Signed-off-by: James

[PATCH] pack-bitmap: Don't perform unaligned memory access

2017-06-26 Thread James Clarke
The preceding bitmap entries have a 1-byte XOR-offset and 1-byte flags, so their size is not a multiple of 4. Thus the name-hash cache is only guaranteed to be 2-byte aligned and so we must use get_be32 rather than indexing the array directly. Signed-off-by: James Clarke --- This was noticed tha