Re: [PATCH] notes: accept any ref for merge

2014-12-04 Thread Jeff King
On Sat, Nov 22, 2014 at 10:04:57AM -0800, Kyle J. McKay wrote: > > By "stealth enabler" I mean the removal of refs/notes/ restriction > > that was originally done as a safety measure to avoid mistakes of > > storing notes outside. The refs/remote-notes/ future direction > > declares that it is no

Re: [PATCH] notes: accept any ref for merge

2014-11-22 Thread Kyle J. McKay
I see this patch has not been picked up. I would like to lobby for inclusion of this patch. On Sep 19, 2014, at 11:22, Junio C Hamano wrote: > Johan Herland writes: > >> On Fri, Sep 19, 2014 at 11:39 AM, Jeff King wrote: >>> On Fri, Sep 19, 2014 at 09:39:45AM +0200, Scott Chacon wrote: Th

Re: [PATCH] notes: accept any ref for merge

2014-09-22 Thread Junio C Hamano
Johan Herland writes: >> Assuming that this is we all agree to go in that direction, let's >> make a list of things to be done to codify it, and do them. For a >> starter, I think these are needed, perhaps? >> ... > Sounds good to me. At least that would ... > ... > In addition to that we might

Re: [PATCH] notes: accept any ref for merge

2014-09-19 Thread Johan Herland
On Fri, Sep 19, 2014 at 8:22 PM, Junio C Hamano wrote: > Johan Herland writes: >> On Fri, Sep 19, 2014 at 11:39 AM, Jeff King wrote: >>> On Fri, Sep 19, 2014 at 09:39:45AM +0200, Scott Chacon wrote: Currently if you try to merge notes, the notes code ensures that the reference is under

Re: [PATCH] notes: accept any ref for merge

2014-09-19 Thread Junio C Hamano
Johan Herland writes: > On Fri, Sep 19, 2014 at 11:39 AM, Jeff King wrote: >> On Fri, Sep 19, 2014 at 09:39:45AM +0200, Scott Chacon wrote: >>> Currently if you try to merge notes, the notes code ensures that the >>> reference is under the 'refs/notes' namespace. In order to do any sort >>> of c

Re: [PATCH] notes: accept any ref for merge

2014-09-19 Thread Junio C Hamano
Jeff King writes: > I think this change affects not just "git notes merge", but all of the > notes lookups (including just "git notes show"). However, I'd argue > that's a good thing, as it allows more flexibility in note storage. The > downside is that if you have a notes ref like > "refs/notes/

Re: [PATCH] notes: accept any ref for merge

2014-09-19 Thread Johan Herland
On Fri, Sep 19, 2014 at 11:39 AM, Jeff King wrote: > On Fri, Sep 19, 2014 at 09:39:45AM +0200, Scott Chacon wrote: >> Currently if you try to merge notes, the notes code ensures that the >> reference is under the 'refs/notes' namespace. In order to do any sort >> of collaborative workflow, this do

Re: [PATCH] notes: accept any ref for merge

2014-09-19 Thread Jeff King
On Fri, Sep 19, 2014 at 09:39:45AM +0200, Scott Chacon wrote: > Currently if you try to merge notes, the notes code ensures that the > reference is under the 'refs/notes' namespace. In order to do any sort > of collaborative workflow, this doesn't work well as you can't easily > have local notes r

[PATCH] notes: accept any ref for merge

2014-09-19 Thread Scott Chacon
Currently if you try to merge notes, the notes code ensures that the reference is under the 'refs/notes' namespace. In order to do any sort of collaborative workflow, this doesn't work well as you can't easily have local notes refs seperate from remote notes refs. This patch changes the expand_not