Re: [PATCH] mingw: allow hooks to be .exe files

2017-01-30 Thread Johannes Schindelin
Hi Stefan, On Fri, 27 Jan 2017, Stefan Beller wrote: > On Fri, Jan 27, 2017 at 2:29 AM, Johannes Schindelin > wrote: > > Hi Junio, > > > > On Thu, 26 Jan 2017, Junio C Hamano wrote: > > > >> Johannes Schindelin writes: > >> > >> > On Wed, 25 Jan 2017, Jeff King wrote: > >> > > >> > v2 coming, >

Re: [PATCH] mingw: allow hooks to be .exe files

2017-01-27 Thread Stefan Beller
On Fri, Jan 27, 2017 at 2:29 AM, Johannes Schindelin wrote: > Hi Junio, > > On Thu, 26 Jan 2017, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > On Wed, 25 Jan 2017, Jeff King wrote: >> > >> >> On Wed, Jan 25, 2017 at 05:58:42PM +0100, Johannes Schindelin wrote: >> >> >> >> > -

Re: [PATCH] mingw: allow hooks to be .exe files

2017-01-27 Thread Johannes Schindelin
Hi Junio, On Thu, 26 Jan 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > On Wed, 25 Jan 2017, Jeff King wrote: > > > >> On Wed, Jan 25, 2017 at 05:58:42PM +0100, Johannes Schindelin wrote: > >> > >> > -if (access(path.buf, X_OK) < 0) > >> > +if (access(path.buf,

Re: [PATCH] mingw: allow hooks to be .exe files

2017-01-26 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Peff, > > On Wed, 25 Jan 2017, Jeff King wrote: > >> On Wed, Jan 25, 2017 at 05:58:42PM +0100, Johannes Schindelin wrote: >> >> > - if (access(path.buf, X_OK) < 0) >> > + if (access(path.buf, X_OK) < 0) { >> > +#ifdef STRIP_EXTENSION >> > + strbuf_adds

Re: [PATCH] mingw: allow hooks to be .exe files

2017-01-26 Thread Johannes Schindelin
Hi Junio, On Wed, 25 Jan 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > This change is necessary to allow the files in .git/hooks/ to optionally > > have the file extension `.exe` on Windows, as the file names are > > hardcoded otherwise. > > Hmph. There is no longer ".com"?

Re: [PATCH] mingw: allow hooks to be .exe files

2017-01-26 Thread Johannes Schindelin
Hi Peff, On Wed, 25 Jan 2017, Jeff King wrote: > On Wed, Jan 25, 2017 at 05:58:42PM +0100, Johannes Schindelin wrote: > > > - if (access(path.buf, X_OK) < 0) > > + if (access(path.buf, X_OK) < 0) { > > +#ifdef STRIP_EXTENSION > > + strbuf_addstr(&path, ".exe"); > > I think STRIP_E

Re: [PATCH] mingw: allow hooks to be .exe files

2017-01-25 Thread Junio C Hamano
Jeff King writes: > On Wed, Jan 25, 2017 at 05:58:42PM +0100, Johannes Schindelin wrote: > >> This change is necessary to allow the files in .git/hooks/ to optionally >> have the file extension `.exe` on Windows, as the file names are >> hardcoded otherwise. > > Make sense as a goal. > >> -if

Re: [PATCH] mingw: allow hooks to be .exe files

2017-01-25 Thread Junio C Hamano
Johannes Schindelin writes: > This change is necessary to allow the files in .git/hooks/ to optionally > have the file extension `.exe` on Windows, as the file names are > hardcoded otherwise. Hmph. There is no longer ".com"? I briefly wondered if hooks/post-receive.{py,rb,...} would be good t

Re: [PATCH] mingw: allow hooks to be .exe files

2017-01-25 Thread Jeff King
On Wed, Jan 25, 2017 at 05:58:42PM +0100, Johannes Schindelin wrote: > This change is necessary to allow the files in .git/hooks/ to optionally > have the file extension `.exe` on Windows, as the file names are > hardcoded otherwise. Make sense as a goal. > - if (access(path.buf, X_OK) < 0)

[PATCH] mingw: allow hooks to be .exe files

2017-01-25 Thread Johannes Schindelin
This change is necessary to allow the files in .git/hooks/ to optionally have the file extension `.exe` on Windows, as the file names are hardcoded otherwise. Signed-off-by: Johannes Schindelin --- Published-As: https://github.com/dscho/git/releases/tag/exe-as-hook-v1 Fetch-It-Via: git fetch http