Re: [PATCH] log: re-encode commit messages before grepping

2013-02-11 Thread Jeff King
On Mon, Feb 11, 2013 at 01:11:24PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > 1. I suppose we could also use $LANG or one of the $LC_* variables to > > guess at the encoding of the user's pattern. But I think using the > > output encoding makes the most sense, since then

Re: [PATCH] log: re-encode commit messages before grepping

2013-02-11 Thread Junio C Hamano
Jeff King writes: > 1. I suppose we could also use $LANG or one of the $LC_* variables to > guess at the encoding of the user's pattern. But I think using the > output encoding makes the most sense, since then the pattern you > searched for will actually be in the output. I agre

[PATCH] log: re-encode commit messages before grepping

2013-02-11 Thread Jeff King
If you run "git log --grep=foo", we will run your regex on the literal bytes of the commit message. This can provide confusing results if the commit message is not in the same encoding as your grep expression (or worse, you have commits in multiple encodings, in which case your regex would need to