Re: [PATCH] interpret-trailers: load default config

2019-06-19 Thread Jeff King
On Wed, Jun 19, 2019 at 07:24:10AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Subject: [PATCH] interpret-trailers: load default config > > > > The interpret-trailers program does not do the usual loading of config > > via git_default_config(), and thu

Re: [PATCH] interpret-trailers: load default config

2019-06-19 Thread Masahiro Yamada
t's that big a deal in practice, though. As I said above, the > idea is that comments would be removed before making it into commit > objects anyway. So we shouldn't be seeing comments, and so the code to > recognize them is not likely to trigger (and I think it would be > reasona

Re: [PATCH] interpret-trailers: load default config

2019-06-19 Thread Junio C Hamano
Jeff King writes: > Subject: [PATCH] interpret-trailers: load default config > > The interpret-trailers program does not do the usual loading of config > via git_default_config(), and thus does not respect many of the usual > options. In particular, we will not load core.commentCh

[PATCH] interpret-trailers: load default config

2019-06-18 Thread Jeff King
m is not likely to trigger (and I think it would be reasonably hard to trigger a false positive accidentally). If you or somebody else wants to dig into it, be my guest, but I don't think I'd prioritize it. -- >8 -- Subject: [PATCH] interpret-trailers: load default config The inter