Re: [PATCH] init-db: remove unused #includes

Jeff King writes: > On Thu, Jan 15, 2015 at 12:36:00PM -0800, Junio C Hamano wrote: > >> Jeff King writes: >> >> > FWIW, the full set of CFLAGS I use (which I specify in config.mak) is: >> > >> > CFLAGS += -Wall -Werror >> > CFLAGS += -Wno-format-zero-length >> > CFLAGS += -Wdeclara

Re: [PATCH] init-db: remove unused #includes

On Thu, Jan 15, 2015 at 12:36:00PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > FWIW, the full set of CFLAGS I use (which I specify in config.mak) is: > > > > CFLAGS += -Wall -Werror > > CFLAGS += -Wno-format-zero-length > > CFLAGS += -Wdeclaration-after-statement > > C

Re: [PATCH] init-db: remove unused #includes

Jeff King writes: > FWIW, the full set of CFLAGS I use (which I specify in config.mak) is: > > CFLAGS += -Wall -Werror > CFLAGS += -Wno-format-zero-length > CFLAGS += -Wdeclaration-after-statement > CFLAGS += -Wpointer-arith > CFLAGS += -Wstrict-prototypes > CFLAGS += -Wol

Re: [PATCH] init-db: remove unused #includes

On Thu, Jan 15, 2015 at 04:13:00PM +0600, Alexander Kuleshov wrote: > yes right, missed system_path usage. But it's strange, code still > compiles successfully without exec_cmd.h. Sort of. With your patch I get: builtin/init-db.c: In function ‘copy_templates’: builtin/init-db.c:127:3: warning: i

Re: [PATCH] init-db: remove unused #includes

Hello Junio, yes right, missed system_path usage. But it's strange, code still compiles successfully without exec_cmd.h. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

Re: [PATCH] init-db: remove unused #includes

Junio C Hamano writes: > Alexander Kuleshov writes: > >> * "cache.h" - is unnecessary because it already included at "builtin.h" >> >> * "exec_cmd.h" - was added at a47d1813 (Allow a relative builtin template >> directory., 15 Nov 2007). init-db used 'git_exec_path' routine from >> "exec_cmd.h",

Re: [PATCH] init-db: remove unused #includes

Alexander Kuleshov writes: > * "cache.h" - is unnecessary because it already included at "builtin.h" > > * "exec_cmd.h" - was added at a47d1813 (Allow a relative builtin template > directory., 15 Nov 2007). init-db used 'git_exec_path' routine from > "exec_cmd.h", but later it was removed at 2de9

[PATCH] init-db: remove unused #includes

* "cache.h" - is unnecessary because it already included at "builtin.h" * "exec_cmd.h" - was added at a47d1813 (Allow a relative builtin template directory., 15 Nov 2007). init-db used 'git_exec_path' routine from "exec_cmd.h", but later it was removed at 2de9de5e (Move code interpreting path rela