Re: [PATCH] index-pack: reduce memory footprint a bit

2015-02-11 Thread Duy Nguyen
On Wed, Feb 11, 2015 at 8:01 PM, matthew sporleder wrote: > On Tue, Feb 10, 2015 at 12:49 PM, Junio C Hamano wrote: >> matthew sporleder writes: >> >>> I'm having trouble getting this new patch to apply. >> >> Apply the first one, replace all object_entry_extra with >> object_stat, replace all o

Re: [PATCH] index-pack: reduce memory footprint a bit

2015-02-11 Thread matthew sporleder
On Tue, Feb 10, 2015 at 12:49 PM, Junio C Hamano wrote: > matthew sporleder writes: > >> I'm having trouble getting this new patch to apply. > > Apply the first one, replace all object_entry_extra with > object_stat, replace all objects_extra with obj_stat and amend the > first one. Then apply t

Re: [PATCH] index-pack: reduce memory footprint a bit

2015-02-10 Thread Junio C Hamano
matthew sporleder writes: > I'm having trouble getting this new patch to apply. Apply the first one, replace all object_entry_extra with object_stat, replace all objects_extra with obj_stat and amend the first one. Then apply this one. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] index-pack: reduce memory footprint a bit

2015-02-10 Thread matthew sporleder
I'm having trouble getting this new patch to apply. Are you working on a branch that I can track? On Tue, Feb 10, 2015 at 3:30 AM, Duy Nguyen wrote: > On Mon, Feb 09, 2015 at 11:27:21AM -0800, Junio C Hamano wrote: >> > On a 3.4M object repo that's about 53MB. The saving is less impressive >> >

Re: [PATCH] index-pack: reduce memory footprint a bit

2015-02-10 Thread Duy Nguyen
On Mon, Feb 09, 2015 at 11:27:21AM -0800, Junio C Hamano wrote: > > On a 3.4M object repo that's about 53MB. The saving is less impressive > > compared to index-pack total memory use (about 400MB before delta > > resolving, so the saving is just 13%) > > > > Signed-off-by: Nguyễn Thái Ngọc Duy > >

Re: [PATCH] index-pack: reduce memory footprint a bit

2015-02-09 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > For each object in the input pack, we need one struct object_entry. On > x86-64, this struct is 64 bytes long. Although: > > - The 8 bytes for delta_depth and base_object_no are only useful when >show_stat is set. And it's never set unless someone is debugging

[PATCH] index-pack: reduce memory footprint a bit

2015-02-09 Thread Nguyễn Thái Ngọc Duy
For each object in the input pack, we need one struct object_entry. On x86-64, this struct is 64 bytes long. Although: - The 8 bytes for delta_depth and base_object_no are only useful when show_stat is set. And it's never set unless someone is debugging. - The three fields hdr_size, type and