Re: [PATCH] index-pack: correct --keep[=]

2016-03-03 Thread Eric Sunshine
On Thu, Mar 3, 2016 at 2:14 PM, Junio C Hamano wrote: > When 592ce208 (index-pack: use strip_suffix to avoid magic numbers, > 2014-06-30) refactored the code to derive names of .idx and .keep > files from the name of .pack file, a copy-and-paste typo crept in, > mistakingly attempting to create an

Re: [PATCH] index-pack: correct --keep[=]

2016-03-03 Thread Jeff King
On Thu, Mar 03, 2016 at 11:14:46AM -0800, Junio C Hamano wrote: > When 592ce208 (index-pack: use strip_suffix to avoid magic numbers, > 2014-06-30) refactored the code to derive names of .idx and .keep > files from the name of .pack file, a copy-and-paste typo crept in, > mistakingly attempting to

[PATCH] index-pack: correct --keep[=]

2016-03-03 Thread Junio C Hamano
When 592ce208 (index-pack: use strip_suffix to avoid magic numbers, 2014-06-30) refactored the code to derive names of .idx and .keep files from the name of .pack file, a copy-and-paste typo crept in, mistakingly attempting to create and store the keep message file in the .idx file we just created,