Re: [PATCH] ident.c: add support for IPv6

2015-10-30 Thread Jeff King
On Fri, Oct 30, 2015 at 03:48:07PM +0100, Elia Pinto wrote: > Add IPv6 support by implementing name resolution with the > protocol agnostic getaddrinfo(3) API. The old gethostbyname(3) > code is still available when git is compiled with NO_IPV6. Makes sense. I'm not excited by the duplication in

Re: [PATCH] ident.c: add support for IPv6

2015-10-30 Thread Eric Sunshine
On Fri, Oct 30, 2015 at 1:26 PM, Torsten Bögershausen wrote: > On 2015-10-30 15.48, Elia Pinto wrote: >> Add IPv6 support by implementing name resolution with the >> --- >> +#ifndef NO_IPV6 >> + >> +static void add_domainname(struct strbuf *out) >> +{ >> + char buf[1024]; >> + struct addri

Re: [PATCH] ident.c: add support for IPv6

2015-10-30 Thread Junio C Hamano
Torsten Bögershausen writes: > On 2015-10-30 15.48, Elia Pinto wrote: >> Add IPv6 support by implementing name resolution with the > Minor question: How is this related to IPV6? > Could the header line be written something like > > "ident.c: Use getaddrinfo() instead of gethostbyname() if availab

Re: [PATCH] ident.c: add support for IPv6

2015-10-30 Thread Torsten Bögershausen
On 2015-10-30 15.48, Elia Pinto wrote: > Add IPv6 support by implementing name resolution with the Minor question: How is this related to IPV6? Could the header line be written something like "ident.c: Use getaddrinfo() instead of gethostbyname() if available" On which systems has the patch been

[PATCH] ident.c: add support for IPv6

2015-10-30 Thread Elia Pinto
Add IPv6 support by implementing name resolution with the protocol agnostic getaddrinfo(3) API. The old gethostbyname(3) code is still available when git is compiled with NO_IPV6. Signed-off-by: Elia Pinto --- ident.c | 30 ++ 1 file changed, 30 insertions(+) diff --