Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Jerry Qassar
On Tue, Apr 30, 2013 at 1:29 PM, Jeff King wrote: > On Tue, Apr 30, 2013 at 01:17:03PM -0700, Junio C Hamano wrote: > >> Jerry Qassar writes: >> >> > Curl already does support engine-based certificates (in code and >> > help). Its problem is that a) it doesn't yet read your engine >> > defs out

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Jeff King
On Tue, Apr 30, 2013 at 01:17:03PM -0700, Junio C Hamano wrote: > Jerry Qassar writes: > > > Curl already does support engine-based certificates (in code and > > help). Its problem is that a) it doesn't yet read your engine > > defs out of OpenSSL config, and b) a bug in copying the engine > >

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Jeff King
On Tue, Apr 30, 2013 at 01:04:17PM -0700, Jerry Qassar wrote: > First, thanks very much for taking a look at this. I wasn't 100% certain > about > the versioning to use for it (specifically the version-to-0x mapping), so any > input on that would be a big help. I'll try to answer your questions

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Junio C Hamano
Jerry Qassar writes: > Curl already does support engine-based certificates (in code and > help). Its problem is that a) it doesn't yet read your engine > defs out of OpenSSL config, and b) a bug in copying the engine > data, once that's patched, to the handle that calling apps use. So once the

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Jerry Qassar
On Tue, Apr 30, 2013 at 11:27 AM, Jeff King wrote: > On Tue, Apr 30, 2013 at 09:45:44AM -0700, Junio C Hamano wrote: > >> The authoritative source >> >> https://github.com/bagder/curl/blob/master/docs/libcurl/symbols-in-versions >> >> tells me that the CURLOPT_* used in this patch are available si

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Jeff King
On Tue, Apr 30, 2013 at 09:45:44AM -0700, Junio C Hamano wrote: > The authoritative source > > https://github.com/bagder/curl/blob/master/docs/libcurl/symbols-in-versions > > tells me that the CURLOPT_* used in this patch are available since > cURL 7.9.3, but I see a #if LIBCURL_VERSION_NUM < 0x

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Junio C Hamano
Does anybody familiar with the http codepath have comments on this? The authoritative source https://github.com/bagder/curl/blob/master/docs/libcurl/symbols-in-versions tells me that the CURLOPT_* used in this patch are available since cURL 7.9.3, but I see a #if LIBCURL_VERSION_NUM < 0x070704 i

[PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-23 Thread Jerry Qassar
curl provides many options for configuring the way it negotiates an SSL connection (with its default OpenSSL support), including ways to define the SSL engine used, and parameters to set the format of the key and certificate used. Unfortunately, git does not parse some of the critical ones needed