Re: [PATCH] http-push: workaround for format overflow warning in gcc >= 9

2019-05-12 Thread Junio C Hamano
Eric Sunshine writes: >> if (request->curl_result != CURLE_OK) { >> fprintf(stderr, "Unable to get pack file %s\n%s", >> - request->url, curl_errorstr); >> + request->url ? request->url : "", >> +

Re: [PATCH] http-push: workaround for format overflow warning in gcc >= 9

2019-05-10 Thread Eric Sunshine
On Fri, May 10, 2019 at 2:59 AM Carlo Marcelo Arenas Belón wrote: > In function 'finish_request', > inlined from 'process_response' at http-push.c:248:2: > http-push.c:587:4: warning: '%s' directive argument is null > [-Wformat-overflow=] > 587 |fprintf(stderr, "Unable to get pack file

[PATCH] http-push: workaround for format overflow warning in gcc >= 9

2019-05-09 Thread Carlo Marcelo Arenas Belón
In function 'finish_request', inlined from 'process_response' at http-push.c:248:2: http-push.c:587:4: warning: '%s' directive argument is null [-Wformat-overflow=] 587 |fprintf(stderr, "Unable to get pack file %s\n%s", |^ 588 |