Re: [PATCH] http-push: trim trailing newline from remote symref

2015-01-15 Thread Junio C Hamano
"Kyle J. McKay" writes: > On Jan 13, 2015, at 11:58, Jeff King wrote: > ... > I'm running curl 7.38, and in this context "older" is anything before > 7.40, so that would explain it. curl 7.38 was released 2014-09-10, so > it's only 4 months old at this point. 7.40 was only released 5 days > ago

Re: [PATCH] http-push: trim trailing newline from remote symref

2015-01-13 Thread Kyle J. McKay
On Jan 13, 2015, at 11:58, Jeff King wrote: On Tue, Jan 13, 2015 at 08:26:31AM -0800, Kyle J. McKay wrote: I have this line in my 2.1.4 test output log: t5540-http-push-webdav.sh .. ok [...] I do not build with NO_EXPAT. This is running the tests on OS X without thi

Re: [PATCH] http-push: trim trailing newline from remote symref

2015-01-13 Thread Jeff King
On Mon, Jan 12, 2015 at 09:28:58PM -0500, Jeff King wrote: > When we fetch a symbolic ref file from the remote, we get > the whole string "ref: refs/heads/master\n", recognize it by > skipping past the "ref: ", and store the rest. We should > chomp the trailing newline. > > This bug was introduce

Re: [PATCH] http-push: trim trailing newline from remote symref

2015-01-13 Thread Jeff King
On Tue, Jan 13, 2015 at 08:26:31AM -0800, Kyle J. McKay wrote: > I have this line in my 2.1.4 test output log: > > t5540-http-push-webdav.sh .. ok > [...] > I do not build with NO_EXPAT. This is running the tests on OS X without > this patch applied. Is something else re

Re: [PATCH] http-push: trim trailing newline from remote symref

2015-01-13 Thread Kyle J. McKay
On Jan 12, 2015, at 18:28, Jeff King wrote: When we fetch a symbolic ref file from the remote, we get the whole string "ref: refs/heads/master\n", recognize it by skipping past the "ref: ", and store the rest. We should chomp the trailing newline. [..] This is a regression in v2.1.0. It was cau

[PATCH] http-push: trim trailing newline from remote symref

2015-01-12 Thread Jeff King
When we fetch a symbolic ref file from the remote, we get the whole string "ref: refs/heads/master\n", recognize it by skipping past the "ref: ", and store the rest. We should chomp the trailing newline. This bug was introduced in ae021d8 (use skip_prefix to avoid magic numbers, 2014-06-18), which