Re: [PATCH] http: support CURLPROXY_HTTPS

2017-12-20 Thread Jeff King
On Wed, Dec 20, 2017 at 10:22:06AM +0800, Wei Shuyu wrote: > On 2017-12-20 04:59, Jonathan Nieder wrote: > > > Thanks for writing this. Can you give an example of how I'd use it > > (ideally in the form of a test in t/ so we avoid this functionality > > regressing, but if that's not straightforw

Re: [PATCH] http: support CURLPROXY_HTTPS

2017-12-19 Thread Wei Shuyu
On 2017-12-20 10:22, Wei Shuyu wrote: CURLPROXY_HTTPS is intended for run-time detection. I don't think it's a good idea to use it with #ifdef. s/CURLPROXY_HTTPS/CURL_VERSION_HTTPS_PROXY/

Re: [PATCH] http: support CURLPROXY_HTTPS

2017-12-19 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan Nieder writes: >> Wei Shuyu wrote: >>> diff --git a/http.c b/http.c >>> index 215bebef1..32d33261c 100644 >>> --- a/http.c >>> +++ b/http.c >>> @@ -865,6 +865,11 @@ static CURL *get_curl_handle(void) >>> else if (starts_with(curl_http_proxy, "socks"))

Re: [PATCH] http: support CURLPROXY_HTTPS

2017-12-19 Thread Junio C Hamano
Jonathan Nieder writes: > Hi, > > Wei Shuyu wrote: > >> HTTP proxy over SSL is supported by curl since 7.52.0. >> This is very useful for networks with protocol whitelist. >> >> Signed-off-by: Wei Shuyu >> --- >> http.c | 5 + >> 1 file changed, 5 insertions(+) > > Thanks for writing this.

Re: [PATCH] http: support CURLPROXY_HTTPS

2017-12-19 Thread Jonathan Nieder
Hi, Wei Shuyu wrote: > HTTP proxy over SSL is supported by curl since 7.52.0. > This is very useful for networks with protocol whitelist. > > Signed-off-by: Wei Shuyu > --- > http.c | 5 + > 1 file changed, 5 insertions(+) Thanks for writing this. Can you give an example of how I'd use it

[PATCH] http: support CURLPROXY_HTTPS

2017-12-19 Thread Wei Shuyu
HTTP proxy over SSL is supported by curl since 7.52.0. This is very useful for networks with protocol whitelist. Signed-off-by: Wei Shuyu --- http.c | 5 + 1 file changed, 5 insertions(+) diff --git a/http.c b/http.c index 215bebef1..32d33261c 100644 --- a/http.c +++ b/http.c @@ -865,6 +865