Re: [PATCH] http: always use any proxy auth method available

2015-06-29 Thread Junio C Hamano
Enrique Tobis writes: > You did guess correctly. As you said you are not an expert in this > area, should I wait until someone else chimes in or is this enough to > resubmit for inclusion? Assuming my revised explanation is acceptable, > of course. I'll queue the patch as-is with your updated lo

RE: [PATCH] http: always use any proxy auth method available

2015-06-26 Thread Enrique Tobis
Thanks for your feedback! > -Original Message- > From: Junio C Hamano [mailto:jch2...@gmail.com] On Behalf Of Junio C > Hamano > Sent: Friday, June 26, 2015 15:25 > To: Enrique Tobis > Cc: 'git@vger.kernel.org'; 'Nelson Benitez Leon' > Subject: Re

Re: [PATCH] http: always use any proxy auth method available

2015-06-26 Thread Junio C Hamano
Enrique Tobis writes: Thanks. I wonder why this was addressed me directly (i.e. I am not an area expert, and I haven't seen this patch discussed here and reviewed by other people), but anyway... > By default, libcurl honors some environment variables that specify a > proxy (e.g. http_proxy, htt

[PATCH] http: always use any proxy auth method available

2015-06-26 Thread Enrique Tobis
By default, libcurl honors some environment variables that specify a proxy (e.g. http_proxy, https_proxy). Also by default, libcurl will only try to authenticate with a proxy using the Basic method. This change makes libcurl always try the most secure proxy authentication method available. As a con