Re: [PATCH] hook: use correct logical variable

2017-08-16 Thread Kaartic Sivaraam
On Tue, 2017-08-15 at 10:28 -0700, Junio C Hamano wrote: > I did shoot for conciseness, but what is a lot more important is to > record what is at the core of the issue. "I found it by doing A" > can hint to careful readers why doing A leads to an undesirable > behaviour, but when there are other

Re: [PATCH] hook: use correct logical variable

2017-08-15 Thread Junio C Hamano
Kaartic Sivaraam writes: > I guess Junio's suggestion found below seems concise enough > although it doesn't capture the reason I did the change. I did shoot for conciseness, but what is a lot more important is to record what is at the core of the issue. "I found it by doing A" can hint to care

Re: [PATCH] hook: use correct logical variable

2017-08-15 Thread Kaartic Sivaraam
On Monday 14 August 2017 11:49 PM, Junio C Hamano wrote: I tend to agree with "Anyways" above ;-) simply because I found the long paragraph more confusing than enlightening, leaving me wonder "why is the user using different settings for author and committer name" at the end, which _is_ an irrele

Re: [PATCH] hook: use correct logical variable

2017-08-15 Thread Kaartic Sivaraam
On Monday 14 August 2017 11:24 PM, Stefan Beller wrote: On Mon, Aug 14, 2017 at 1:46 AM, Kaartic Sivaraam wrote: Sign-off added should be that of the "committer" not that of the "commit's author". Use the correct logical variable that identifies the committer. Signed-off-by: Kaartic Sivaraam

Re: [PATCH] hook: use correct logical variable

2017-08-14 Thread Junio C Hamano
Kaartic Sivaraam writes: > Sign-off added should be that of the "committer" not that of the > "commit's author". > > Use the correct logical variable that identifies the committer. > > Signed-off-by: Kaartic Sivaraam > --- > This fixes a small issue when trying to do the following with the scri

Re: [PATCH] hook: use correct logical variable

2017-08-14 Thread Stefan Beller
On Mon, Aug 14, 2017 at 1:46 AM, Kaartic Sivaraam wrote: > Sign-off added should be that of the "committer" not that of the > "commit's author". > > Use the correct logical variable that identifies the committer. > > Signed-off-by: Kaartic Sivaraam > --- > This fixes a small issue when trying to

[PATCH] hook: use correct logical variable

2017-08-14 Thread Kaartic Sivaraam
Sign-off added should be that of the "committer" not that of the "commit's author". Use the correct logical variable that identifies the committer. Signed-off-by: Kaartic Sivaraam --- This fixes a small issue when trying to do the following with the script enabled, $ git commit --amend -s