Re: [PATCH] help: Fix size passed to qsort

2014-09-18 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> We actually want to have the size of one 'name' and not the size >> of the names array. > ... > I suspect that the latter is "size of a pointer that points at a > cmdname structure", but the original code in help_unknown_cmd() is > wrong. The

Re: [PATCH] help: Fix size passed to qsort

2014-09-18 Thread Junio C Hamano
Stefan Beller writes: > We actually want to have the size of one 'name' and not the size > of the names array. I suspect that the latter is "size of a pointer that points at a cmdname structure", but the original code in help_unknown_cmd() is wrong. The ones in load_command_list() do this corre

[PATCH] help: Fix size passed to qsort

2014-09-17 Thread Stefan Beller
We actually want to have the size of one 'name' and not the size of the names array. Signed-off-by: Stefan Beller --- help.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/help.c b/help.c index 7af65e2..2072a87 100644 --- a/help.c +++ b/help.c @@ -305,7 +305,7 @@ const char