Re: [PATCH] grep.c: Fix a sparse warning

2012-09-18 Thread Junio C Hamano
Ramsay Jones writes: > In particular, sparse complains that "... 'dump_grep_expression' > was not declared. Should it be static?". In order to suppress > the warning, since this function does not need more than file > scope, we simply include the static modifier in it's declaration. > > Signed-of

[PATCH] grep.c: Fix a sparse warning

2012-09-18 Thread Ramsay Jones
In particular, sparse complains that "... 'dump_grep_expression' was not declared. Should it be static?". In order to suppress the warning, since this function does not need more than file scope, we simply include the static modifier in it's declaration. Signed-off-by: Ramsay Jones --- Hi Junio