Re: [PATCH] grep: use return value of strbuf_detach()

2019-08-26 Thread Johannes Schindelin
Hi René, On Sun, 25 Aug 2019, René Scharfe wrote: > Append the strbuf buffer only after detaching it. There is no practical > difference here, as the strbuf is not empty and no strbuf_ function is > called between storing the pointer to the still attached buffer and > calling strbuf_detach(), so

[PATCH] grep: use return value of strbuf_detach()

2019-08-25 Thread René Scharfe
Append the strbuf buffer only after detaching it. There is no practical difference here, as the strbuf is not empty and no strbuf_ function is called between storing the pointer to the still attached buffer and calling strbuf_detach(), so that pointer is valid, but make sure to follow the standard