Re: [PATCH] grep: print the pcre2_jit_on value

2019-07-29 Thread Carlo Arenas
On Thu, Jul 25, 2019 at 5:50 AM Johannes Schindelin wrote: > On Wed, 24 Jul 2019, Beat Bolli wrote: > > Do you mean something like this? > > Yes! Ideally, though, you want to print those values closing to the match function (pcre_exec for PCRE1 or pcre2_[jit_]match for PCRE2 as they might change

Re: [PATCH] grep: print the pcre2_jit_on value

2019-07-25 Thread Johannes Schindelin
Hi Beat, On Wed, 24 Jul 2019, Beat Bolli wrote: > On 23.07.19 21:19, Johannes Schindelin wrote: > > > > On Mon, 22 Jul 2019, Beat Bolli wrote: > > > >> When pcre2_jit_on is neither 1 nor 0, the BUG() call printed the value > >> of pcre1_jit_on. > >> > >> Print the value of pcre2_jit_on instead. >

Re: [PATCH] grep: print the pcre2_jit_on value

2019-07-24 Thread Beat Bolli
Hi Dscho, On 23.07.19 21:19, Johannes Schindelin wrote: > Hi Beat, > > On Mon, 22 Jul 2019, Beat Bolli wrote: > >> When pcre2_jit_on is neither 1 nor 0, the BUG() call printed the value >> of pcre1_jit_on. >> >> Print the value of pcre2_jit_on instead. >> >> Signed-off-by: Beat Bolli >> --- >>

Re: [PATCH] grep: print the pcre2_jit_on value

2019-07-23 Thread Johannes Schindelin
Hi Beat, On Mon, 22 Jul 2019, Beat Bolli wrote: > When pcre2_jit_on is neither 1 nor 0, the BUG() call printed the value > of pcre1_jit_on. > > Print the value of pcre2_jit_on instead. > > Signed-off-by: Beat Bolli > --- > grep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] grep: print the pcre2_jit_on value

2019-07-23 Thread Junio C Hamano
Beat Bolli writes: > When pcre2_jit_on is neither 1 nor 0, the BUG() call printed the value > of pcre1_jit_on. > > Print the value of pcre2_jit_on instead. > > Signed-off-by: Beat Bolli > --- Thanks. > grep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/grep.c b/g

[PATCH] grep: print the pcre2_jit_on value

2019-07-22 Thread Beat Bolli
When pcre2_jit_on is neither 1 nor 0, the BUG() call printed the value of pcre1_jit_on. Print the value of pcre2_jit_on instead. Signed-off-by: Beat Bolli --- grep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grep.c b/grep.c index f7c3a5803e..cd952ef5d3 100644 --- a/gre