Re: [PATCH] gpg-interface.c: detect and reject multiple signatures on commits

2018-08-17 Thread Junio C Hamano
Jonathan Nieder writes: > Michał Górny wrote: > >> GnuPG supports creating signatures consisting of multiple signature >> packets. If such a signature is verified, it outputs all the status >> messages for each signature separately. However, git currently does not >> account for such scenario a

Re: [PATCH] gpg-interface.c: detect and reject multiple signatures on commits

2018-08-16 Thread Jonathan Nieder
Michał Górny wrote: > On Wed, 2018-08-15 at 14:31 -0700, Jonathan Nieder wrote: >> It's not clear to me that the name is_status or SIGNATURE_STATUS >> captures what this field represents. Aren't these all sigcheck >> statuses? Can you describe briefly what distinguishes the cases where >> this s

Re: [PATCH] gpg-interface.c: detect and reject multiple signatures on commits

2018-08-16 Thread Michał Górny
On Wed, 2018-08-15 at 14:31 -0700, Jonathan Nieder wrote: > Michał Górny wrote: > > > GnuPG supports creating signatures consisting of multiple signature > > packets. If such a signature is verified, it outputs all the status > > messages for each signature separately. However, git currently doe

Re: [PATCH] gpg-interface.c: detect and reject multiple signatures on commits

2018-08-15 Thread Jonathan Nieder
Michał Górny wrote: > GnuPG supports creating signatures consisting of multiple signature > packets. If such a signature is verified, it outputs all the status > messages for each signature separately. However, git currently does not > account for such scenario and gets terribly confused over ge