Re: [PATCH] gitweb: fix link to parent diff with pathinfo

2016-05-25 Thread Richard Braun
On Wed, May 25, 2016 at 10:33:32PM +0200, Jakub Narębski wrote: > Richard, thanks for finding a problematic thing, but you > need to search more for a true fix. Noted, I'll get back to you soon (hopefully not too late). -- Richard Braun -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] gitweb: fix link to parent diff with pathinfo

2016-05-25 Thread Jakub Narębski
On Tue, May 24, 2016 at 8:17 PM, Junio C Hamano wrote: > Richard Braun writes: > >> Gitweb, when used with PATH_INFO, shows a link to parent diff >> like http://somedomain/somerepo.git/commitdiff/somehash?hp=parenthash. >> That link reports "400 - Invalid hash parameter". Richard, at which view

Re: [PATCH] gitweb: fix link to parent diff with pathinfo

2016-05-24 Thread Junio C Hamano
Richard Braun writes: > On Tue, May 24, 2016 at 11:17:28AM -0700, Junio C Hamano wrote: >> Pinging... > > Hum, see [1]. > > Tell me if I need to resend. Sorry, check the "To:" field of the message you are responding to. The ping was not meant to (and was not addressed to) you. It asked for comm

Re: [PATCH] gitweb: fix link to parent diff with pathinfo

2016-05-24 Thread Richard Braun
On Tue, May 24, 2016 at 11:17:28AM -0700, Junio C Hamano wrote: > Pinging... Hum, see [1]. Tell me if I need to resend. -- Richard Braun Pacte Novation / Novasys Ingénierie [1] http://git.661346.n2.nabble.com/PATCH-gitweb-fix-link-to-parent-diff-with-pathinfo-td7655482.html -- To unsubscr

Re: [PATCH] gitweb: fix link to parent diff with pathinfo

2016-05-24 Thread Junio C Hamano
Richard Braun writes: > Gitweb, when used with PATH_INFO, shows a link to parent diff > like http://somedomain/somerepo.git/commitdiff/somehash?hp=parenthash. > That link reports "400 - Invalid hash parameter". > > As I understand it, it should instead directly point to the parent diff, > i.e. tu

[PATCH] gitweb: fix link to parent diff with pathinfo

2016-05-06 Thread Richard Braun
Gitweb, when used with PATH_INFO, shows a link to parent diff like http://somedomain/somerepo.git/commitdiff/somehash?hp=parenthash. That link reports "400 - Invalid hash parameter". As I understand it, it should instead directly point to the parent diff, i.e. turn it into http://somedomain/somere

Re: [PATCH] gitweb: fix link to parent diff with pathinfo

2016-05-06 Thread Junio C Hamano
Richard Braun writes: > Signed-off-by: Richard Braun > --- Could you justify your change with a bit more than "fix"? That is, gitweb, when used with PATH_INFO, shows a link to parent diff like [fill in the blank]. However, it is wrong because [fill in the blank]. Make it sho

[PATCH] gitweb: fix link to parent diff with pathinfo

2016-05-06 Thread Richard Braun
Signed-off-by: Richard Braun --- gitweb/gitweb.perl | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 05d7910..f7f7936 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -1423,7 +1423,12 @@ sub href {