Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Jakub Narębski
On Thu, Jul 4, 2013 at 7:08 PM, Tony Finch wrote: > Jakub Narębski wrote: >> >> In what situation do you need those extra breadcrumbs useful? What >> necessity / itch to scratch is behind idea of this patch? > > For an example, see https://git.csx.cam.ac.uk/x/ucs/git/git.git > > I have three item

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Tony Finch
Jakub Narębski wrote: > > In what situation do you need those extra breadcrumbs useful? What > necessity / itch to scratch is behind idea of this patch? For an example, see https://git.csx.cam.ac.uk/x/ucs/git/git.git I have three items in @extra_breadcrumbs which point to the University home pag

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Jakub Narębski
On Thu, Jul 4, 2013 at 5:56 PM, Tony Finch wrote: > Jakub Narębski wrote: >> >> First, do I understand correctly that @extra_breadcrumbs are rendered *after* >> $home_link*, and in exactly the same manner? > > Before the home link, and yes, in the same manner. The extra breadcrumbs > are for link

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Tony Finch
Jakub Narębski wrote: > > First, do I understand corrctly that @extra_breadcrumbs are rendered *after* > $home_link*, and in exactly the same manner? Before the home link, and yes, in the same manner. The extra breadcrumbs are for links to parent pages above gitweb in some hierarchy. > But now I

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Jakub Narębski
On Thu, Jul 4, 2013 at 5:11 PM, Tony Finch wrote: > Jakub Narębski wrote: >> >> It would be better to improve documentation, than follow current bad >> practice... ;-P > > The v2 patch does just that :-) Thanks. >> Perhaps even make ( [ $home_link_str, $home_link ] ) to be default >> value for

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Tony Finch
Jakub Narębski wrote: > > It would be better to improve documentation, than follow current bad > practice... ;-P The v2 patch does just that :-) > Perhaps even make ( [ $home_link_str, $home_link ] ) to be default > value for @extra_breadcrumbs, making new feature generalization > of $home_link*

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Jakub Narębski
On Thu, Jul 4, 2013 at 10:44 AM, Tony Finch wrote: > Jakub Narębski wrote: >> On Wed, Jul 3, 2013 at 11:59 PM, Jonathan Nieder wrote: >>> Tony Finch wrote: >> +@extra_breadcrumbs:: BTW. perhaps (it is only an idea) @top_level_breadcrumbs or @home_breadcrumbs would be a better name for this

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Tony Finch
Jakub Narębski wrote: > On Wed, Jul 3, 2013 at 11:59 PM, Jonathan Nieder wrote: > > Tony Finch wrote: > > >> +@extra_breadcrumbs:: > >> + Additional links to be added to the start of the breadcrumb trail, > >> + that are logically "above" the gitweb projects list. For example, > >> +

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-03 Thread Jakub Narębski
On Wed, Jul 3, 2013 at 11:59 PM, Jonathan Nieder wrote: > Tony Finch wrote: >> +@extra_breadcrumbs:: >> + Additional links to be added to the start of the breadcrumb trail, >> + that are logically "above" the gitweb projects list. For example, >> + links to the organization and depart

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-03 Thread Jonathan Nieder
(cc-ing Jakub, gitweb wrangler) Tony Finch wrote: > There are often parent pages logically above the gitweb projects > list, e.g. home pages of the organization and department that host > the gitweb server. This change allows you to include links to those > pages in gitweb's breadcrumb trail. Ne

[PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-02 Thread Tony Finch
There are often parent pages logically above the gitweb projects list, e.g. home pages of the organization and department that host the gitweb server. This change allows you to include links to those pages in gitweb's breadcrumb trail. Signed-off-by: Tony Finch --- Documentation/gitweb.conf.txt