Re: [PATCH] gitweb: Added syntax highlight support for golang

2014-02-07 Thread Pavan Kumar Sunkara
Yeah. I agree with you. I am currently looking into allowing users to customize the parameters given to their highlighter. I will try to look into this. Thanks On Sat, Feb 8, 2014 at 4:31 AM, Junio C Hamano wrote: > Pavan Kumar Sunkara writes: > >> Sorry. I misunderstood your message. Yes, I g

Re: [PATCH] gitweb: Added syntax highlight support for golang

2014-02-07 Thread Junio C Hamano
Pavan Kumar Sunkara writes: > Sorry. I misunderstood your message. Yes, I guess lazy loading the > supported file extensions would be better. But not all highlighters > support `-p` option. So, I think its better to leave it to the user. Yes, those highlighters that do not support `-p` may have

Re: [PATCH] gitweb: Added syntax highlight support for golang

2014-02-07 Thread Pavan Kumar Sunkara
Sorry. I misunderstood your message. Yes, I guess lazy loading the supported file extensions would be better. But not all highlighters support `-p` option. So, I think its better to leave it to the user. Thanks -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a mess

Re: [PATCH] gitweb: Added syntax highlight support for golang

2014-02-07 Thread Pavan Kumar Sunkara
The highlight project which is being used by gitweb supports this. I checked it before submitting the patch. Thanks On Sat, Feb 8, 2014 at 3:24 AM, Junio C Hamano wrote: > Pavan Kumar Sunkara writes: > >> Golang is quickly becoming one of the major programming languages. >> >> This change switc

Re: [PATCH] gitweb: Added syntax highlight support for golang

2014-02-07 Thread Junio C Hamano
Pavan Kumar Sunkara writes: > Golang is quickly becoming one of the major programming languages. > > This change switches on golang syntax highlight support by default > in gitweb rather than asking the users to do it using config files. Looks trivially harmless ;-) I haven't touched this part

[PATCH] gitweb: Added syntax highlight support for golang

2014-02-07 Thread Pavan Kumar Sunkara
Golang is quickly becoming one of the major programming languages. This change switches on golang syntax highlight support by default in gitweb rather than asking the users to do it using config files. Signed-off-by: Pavan Kumar Sunkara --- gitweb/gitweb.perl |2 +- 1 file changed, 1 insert