Re: [PATCH] gitweb/INSTALL: Simplify description of GITWEB_CONFIG_SYSTEM

2013-04-16 Thread Drew Northup
On Tue, Apr 16, 2013 at 12:36 AM, Junio C Hamano wrote: > Drew Northup writes: > >>> + Note that the GITWEB_CONFIG_SYSTEM system-wide configuration file is >>> + only used for instances that lack per-instance configuration file. >>> + You can use GITWEB_CONFIG_COMMON common system-wide configu

Re: [PATCH] gitweb/INSTALL: Simplify description of GITWEB_CONFIG_SYSTEM

2013-04-16 Thread Drew Northup
On Tue, Apr 16, 2013 at 3:11 AM, Jakub Narębski wrote: > Junio C Hamano wrote: > >> In order to just pick and use the more appropriate one (or a useful >> combination of the two), a clean description of what each of them do >> without historical cruft is more readable and useful, isn't it? I >> w

Re: [PATCH] gitweb/INSTALL: Simplify description of GITWEB_CONFIG_SYSTEM

2013-04-16 Thread Jakub Narębski
Junio C Hamano wrote: > In order to just pick and use the more appropriate one (or a useful > combination of the two), a clean description of what each of them do > without historical cruft is more readable and useful, isn't it? I > would expect that most of them who are newly configuring a syste

Re: [PATCH] gitweb/INSTALL: Simplify description of GITWEB_CONFIG_SYSTEM

2013-04-15 Thread Junio C Hamano
Drew Northup writes: >> + Note that the GITWEB_CONFIG_SYSTEM system-wide configuration file is >> + only used for instances that lack per-instance configuration file. >> + You can use GITWEB_CONFIG_COMMON common system-wide configuration >> + file (normally /etc/gitweb-common.conf) to keep co

Re: [PATCH] gitweb/INSTALL: Simplify description of GITWEB_CONFIG_SYSTEM

2013-04-15 Thread Drew Northup
On Fri, Apr 12, 2013 at 6:20 PM, Jakub Narębski wrote: > -- >8 -- > Subject: [PATCH] gitweb/INSTALL: Simplify description of GITWEB_CONFIG_SYSTEM > > The flow of the text describing GITWEB_CONFIG_SYSTEM and > GITWEB_CONFIG_COMMON in gitweb/INSTALL is awkward. "This is &

[PATCH] gitweb/INSTALL: Simplify description of GITWEB_CONFIG_SYSTEM

2013-04-12 Thread Jakub Narębski
gt; > Not asking for a re-roll, but it may be a potential follow-up candidate. Perhaps something like this? Note that this change avoids repetition of build / environmental configuration variable (I think the paragraph above, not touched in this patch, also might need rewrite). -- >8 -- S