Re: [PATCH] gittrack.sh accepts invalid branch names

2005-04-20 Thread Pavel Roskin
Hi, Petr! On Thu, 2005-04-21 at 01:21 +0200, Petr Baudis wrote: > Dear diary, on Wed, Apr 20, 2005 at 09:48:30PM CEST, I got a letter > where Pavel Roskin <[EMAIL PROTECTED]> told me that... > > --- a/gittrack.sh > > +++ b/gittrack.sh > > @@ -35,7 +35,7 @@ die () { > > mkdir -p .git/heads > > >

Re: [PATCH] gittrack.sh accepts invalid branch names

2005-04-20 Thread Paul Jackson
Pavel wrote: > sed -ne "/^$name\t/p" .git/remotes | grep -q . Consider using the following to look for a match of $name with the first tab separated field of the remotes file (and to avoid using 'grep -q', which is not in all grep's, so far as I know): cut -f1 .git/remotes | grep -F

Re: [PATCH] gittrack.sh accepts invalid branch names

2005-04-20 Thread Petr Baudis
Dear diary, on Wed, Apr 20, 2005 at 09:48:30PM CEST, I got a letter where Pavel Roskin <[EMAIL PROTECTED]> told me that... > --- a/gittrack.sh > +++ b/gittrack.sh > @@ -35,7 +35,7 @@ die () { > mkdir -p .git/heads > > if [ "$name" ]; then > - grep -q $(echo -e "^$name\t" | sed 's/\./\\./g')

[PATCH] gittrack.sh accepts invalid branch names

2005-04-20 Thread Pavel Roskin
Hello, Petr and everybody! gittrack.sh allows abbreviated branch names, e.g. it's possible to run "git track lin" when there is a branch called "linus". I believe it's a bug, not a feature. Please look at this line from gittrack.sh: grep -q $(echo -e "^$name\t" | sed 's/\./\\./g') .git/remotes