Jeff King writes:
> I don't buy the "gitk should be read-only" argument from that thread. I
> think we decided a while back[1] that the stat cache is not really a
> user-visible modification; you're not updating the index in any
> meaningful way that impacts the user's workflow, but merely refres
On Sun, Sep 30, 2012 at 01:34:58PM -0700, Jonathan Nieder wrote:
> Jeff King wrote:
> > On Sun, Sep 30, 2012 at 10:05:27AM +1000, Paul Mackerras wrote:
>
> >> Unfortunately this will wait for the git update-index command to
> >> complete, making the GUI unresponsive while it executes, and that ca
Hi Jeff,
Jeff King wrote:
> On Sun, Sep 30, 2012 at 10:05:27AM +1000, Paul Mackerras wrote:
>> Unfortunately this will wait for the git update-index command to
>> complete, making the GUI unresponsive while it executes, and that can
>> take minutes on a large repository (e.g. the linux kernel) on
On Sun, Sep 30, 2012 at 10:05:27AM +1000, Paul Mackerras wrote:
> On Fri, Sep 28, 2012 at 04:50:54PM -0400, Jeff King wrote:
>
> > +proc refresh_index {} {
> > +global need_index_refresh
> > +if { $need_index_refresh } {
> > + exec sh -c "git update-index --refresh >/dev/null 2>&1 || tr
On Fri, Sep 28, 2012 at 04:50:54PM -0400, Jeff King wrote:
> +proc refresh_index {} {
> +global need_index_refresh
> +if { $need_index_refresh } {
> + exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"
> + set need_index_refresh false
> +}
> +}
Unfortunately this
Junio C Hamano writes:
> Jeff King writes:
>
>> On Sat, Sep 29, 2012 at 12:11:58AM +0200, Andreas Schwab wrote:
>>
>>> Jeff King writes:
>>>
>>> > +proc refresh_index {} {
>>> > +global need_index_refresh
>>> > +if { $need_index_refresh } {
>>> > + exec sh -c "git update-index --refres
Jeff King writes:
> I think the weird tcl-catches-stderr thing kicks in (at least it did for
> me in a simple experiment). But like I said, I am not an expert.
OK, I'll believe you ;-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.k
On Fri, Sep 28, 2012 at 04:02:32PM -0700, Junio C Hamano wrote:
> >> Jeff King writes:
> >>
> >> > +proc refresh_index {} {
> >> > +global need_index_refresh
> >> > +if { $need_index_refresh } {
> >> > +exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"
> >>
> >> I
Jeff King writes:
> On Sat, Sep 29, 2012 at 12:11:58AM +0200, Andreas Schwab wrote:
>
>> Jeff King writes:
>>
>> > +proc refresh_index {} {
>> > +global need_index_refresh
>> > +if { $need_index_refresh } {
>> > + exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"
>>
>> I
On Sat, Sep 29, 2012 at 12:11:58AM +0200, Andreas Schwab wrote:
> Jeff King writes:
>
> > +proc refresh_index {} {
> > +global need_index_refresh
> > +if { $need_index_refresh } {
> > + exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"
>
> I think the usual idiom for ign
Jeff King writes:
> +proc refresh_index {} {
> +global need_index_refresh
> +if { $need_index_refresh } {
> + exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"
I think the usual idiom for ignoring errors is to use catch around exec,
avoiding the extra shell wrapper:
Jeff King writes:
> Potentially the "reload" command should reset the need_index_refresh
> flag, too.
Yeah, I think that is a sane enhancement to think about.
> gitk | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/gitk b/gitk
> index 379582a..561be23 100755
> --- a/gitk
>
is not refreshing the index at all. Try this (substitute
Makefile with some file in your repository):
$ touch Makefile
$ gitk <-- reports uncommitted changes
$ git update-index --refresh
$ gitk <-- changes go away
I am not a tcl hacker, but the patch below seems to fix it for me.
-
13 matches
Mail list logo
