Re: [PATCH] gitk: catch mkdtemp errors

2014-06-27 Thread Junio C Hamano
Paul Mackerras writes: > On Thu, Jun 26, 2014 at 01:47:36PM -0700, Junio C Hamano wrote: >> >> In the meantime, I've fetched from you and merged up to your >> master~2 aka 17f9836c (gitk: Show staged submodules regardless of >> ignore config, 2014-04-08). > > I have applied and pushed out this p

Re: [PATCH] gitk: catch mkdtemp errors

2014-06-27 Thread Paul Mackerras
On Wed, Jun 18, 2014 at 07:53:14PM -0700, David Aguilar wrote: > 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency > on mkdtemp, which is not available on Windows. > > Use the original temporary directory behavior when mkdtemp fails. > This makes the code use mkdtemp when available

Re: [PATCH] gitk: catch mkdtemp errors

2014-06-27 Thread Paul Mackerras
On Thu, Jun 26, 2014 at 01:47:36PM -0700, Junio C Hamano wrote: > David Aguilar writes: > > > 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency > > on mkdtemp, which is not available on Windows. > > > > Use the original temporary directory behavior when mkdtemp fails. > > This make

Re: [PATCH] gitk: catch mkdtemp errors

2014-06-26 Thread David Aguilar
On Thu, Jun 26, 2014 at 01:42:04PM -0700, Junio C Hamano wrote: > David Aguilar writes: > > > 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency > > on mkdtemp, which is not available on Windows. > > > > Use the original temporary directory behavior when mkdtemp fails. > > This make

Re: [PATCH] gitk: catch mkdtemp errors

2014-06-26 Thread Junio C Hamano
David Aguilar writes: > 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency > on mkdtemp, which is not available on Windows. > > Use the original temporary directory behavior when mkdtemp fails. > This makes the code use mkdtemp when available and gracefully > fallback to the existin

Re: [PATCH] gitk: catch mkdtemp errors

2014-06-26 Thread Junio C Hamano
David Aguilar writes: > 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency > on mkdtemp, which is not available on Windows. > > Use the original temporary directory behavior when mkdtemp fails. > This makes the code use mkdtemp when available and gracefully > fallback to the existin

[PATCH] gitk: catch mkdtemp errors

2014-06-18 Thread David Aguilar
105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency on mkdtemp, which is not available on Windows. Use the original temporary directory behavior when mkdtemp fails. This makes the code use mkdtemp when available and gracefully fallback to the existing behavior when it is not available