Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-13 Thread Junio C Hamano
Martin Langhoff writes: > On Mon, May 13, 2013 at 3:33 PM, Jonathan Nieder wrote: >> Well, no, it should find the final change that brought it into the >> current form. Just like "git blame". >> >> Has it been finding zero results in some cases where the current code >> matches the pattern? Th

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-13 Thread Jonathan Nieder
Ramkumar Ramachandra wrote: > I still don't know exactly what -G and -S do. If you've been following recent gitk development (or this thread) closely, you'll know that "git log -S" finds commits adding/removing a string, while "git log -G" finds commits changing lines matching a regex. Examples

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-13 Thread Ramkumar Ramachandra
Jonathan Nieder wrote: > Martin Langhoff wrote: >> On Mon, May 13, 2013 at 2:55 PM, Jonathan Nieder wrote: > >>> My experience is the opposite. I wonder "What did the author of this >>> nonsense comment mean?" or "What is the purpose of this strange >>> condition in this if () statement?". Then

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-13 Thread Martin Langhoff
On Mon, May 13, 2013 at 3:33 PM, Jonathan Nieder wrote: > Well, no, it should find the final change that brought it into the > current form. Just like "git blame". > > Has it been finding zero results in some cases where the current code > matches the pattern? That sounds like a bug. Ummm, mayb

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-13 Thread Jonathan Nieder
Martin Langhoff wrote: > On Mon, May 13, 2013 at 2:55 PM, Jonathan Nieder wrote: >> My experience is the opposite. I wonder "What did the author of this >> nonsense comment mean?" or "What is the purpose of this strange >> condition in this if () statement?". Then "git log -S" finds the >> culp

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-13 Thread Martin Langhoff
On Mon, May 13, 2013 at 2:55 PM, Jonathan Nieder wrote: > My experience is the opposite. I wonder "What did the author of this > nonsense comment mean?" or "What is the purpose of this strange > condition in this if () statement?". Then "git log -S" finds the > culprit Only if that if () statem

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-13 Thread Jonathan Nieder
Martin Langhoff wrote: > And to be honest, log -G is so much more useful that I don't care a > s***t for log -S. Fair enough. :) [...] > In other words: You find a suspicious-looking line of code and you ask > "how did this horrid code come to be?", and the more horrendous the > code is, the mor

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-13 Thread Jonathan Nieder
Paul Mackerras wrote: > How about "changing lines matching:"? Sorry for the slow response. Sounds perfect. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majo

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-13 Thread Martin Langhoff
On Sat, May 11, 2013 at 5:41 AM, Paul Mackerras wrote: > On Fri, May 10, 2013 at 11:13:22PM -0700, Jonathan Nieder wrote: >> Paul Mackerras wrote: >> >> > I thought I had replied to this patch; maybe I only thought about it. >> > >> > Given that we already have a selector to choose between exact a

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-11 Thread Paul Mackerras
On Fri, May 10, 2013 at 11:13:22PM -0700, Jonathan Nieder wrote: > Paul Mackerras wrote: > > > I thought I had replied to this patch; maybe I only thought about it. > > > > Given that we already have a selector to choose between exact and > > regexp matching, it seems more natural to use that rath

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-10 Thread Jonathan Nieder
Paul Mackerras wrote: > I thought I had replied to this patch; maybe I only thought about it. > > Given that we already have a selector to choose between exact and > regexp matching, it seems more natural to use that rather than add a > new selector entry. Arguably the "IgnCase" option should be

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-10 Thread Paul Mackerras
On Tue, May 07, 2013 at 01:17:18PM -0400, Martin Langhoff wrote: > I just did git rebase origin/master for the umpteenth time, which > reminded me this nice patch is still pending. > > ping? I thought I had replied to this patch; maybe I only thought about it. Given that we already have a select

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-07 Thread Felipe Contreras
On Tue, May 7, 2013 at 12:17 PM, Martin Langhoff wrote: > I just did git rebase origin/master for the umpteenth time, which > reminded me this nice patch is still pending. > > ping? For some reason getting patches into gitk takes a long long looong time. -- Felipe Contreras -- To unsubscribe fr

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-07 Thread Martin Langhoff
I just did git rebase origin/master for the umpteenth time, which reminded me this nice patch is still pending. ping? m On Thu, Jun 14, 2012 at 2:34 PM, Zbigniew Jędrzejewski-Szmek wrote: > From: Martin Langhoff > > git log -G'regex' is a very usable alternative to the classic > pickaxe. Min