Re: [PATCH] gitk: Make web links clickable

2019-08-28 Thread Junio C Hamano
Paul Mackerras writes: > I was expecting some comments and suggestions, so I didn't push it out > yet. One suggestion which seems reasonable is to match any http or > https URL anywhere in the commit description, not just with Link: or > BugLink: at the start of the line. What do you think of t

Re: [PATCH] gitk: Make web links clickable

2019-08-28 Thread Paul Mackerras
Hi Junio, On Tue, Aug 27, 2019 at 01:32:30PM -0700, Junio C Hamano wrote: > Paul Mackerras writes: > > > This makes gitk look for lines in the commit message which start with > > "Link:" or "BugLink:" followed by a http or https URL, and make the > > URL clickable. Clicking on it will invoke an

Re: [PATCH] gitk: Make web links clickable

2019-08-27 Thread Pratyush Yadav
On 27/08/19 08:14AM, Paul Mackerras wrote: > This makes gitk look for lines in the commit message which start with > "Link:" or "BugLink:" followed by a http or https URL, and make the > URL clickable. Clicking on it will invoke an external web browser with > the URL. Why just lines starting wit

Re: [PATCH] gitk: Make web links clickable

2019-08-27 Thread Junio C Hamano
Paul Mackerras writes: > This makes gitk look for lines in the commit message which start with > "Link:" or "BugLink:" followed by a http or https URL, and make the > URL clickable. Clicking on it will invoke an external web browser with > the URL. > > The web browser command is by default "xdg-

Re: [PATCH] gitk: Make web links clickable

2019-08-27 Thread Barret Rhoden
On 8/26/19 6:14 PM, Paul Mackerras wrote: This makes gitk look for lines in the commit message which start with "Link:" or "BugLink:" followed by a http or https URL, and make the URL clickable. Clicking on it will invoke an external web browser with the URL. The web browser command is by defau

[PATCH] gitk: Make web links clickable

2019-08-26 Thread Paul Mackerras
This makes gitk look for lines in the commit message which start with "Link:" or "BugLink:" followed by a http or https URL, and make the URL clickable. Clicking on it will invoke an external web browser with the URL. The web browser command is by default "xdg-open" on Linux, "open" on MacOS, and