On Tue, Sep 08, 2015 at 10:18:41AM -0700, Junio C Hamano wrote:
> > To make the flow easier to follow, let's just set
> > conn->use_shell when we're setting up the "conn" struct, and
> > unset it (with a comment) in the historical GIT_SSH case.
>
> Makes perfect sense. I think another thing that
Jeff King writes:
> Subject: [PATCH] git_connect: clarify conn->use_shell flag
>
> When executing user-specified programs, we generally always
> want to use a shell, for flexibility and consistency. One
> big exception is executing $GIT_SSH, which for historical
> reasons
is could be moved in front of the if, and replaced with
> something like conn>use_shell = !(procol == PROTO_SSH), but maybe this
> would kill legibility. It's just that a single line i the else clause
> of a large if looks odd.
Yeah, I noticed that, too, but I wanted to keep the dif
3 matches
Mail list logo
