Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

2016-01-27 Thread Junio C Hamano
Duy Nguyen writes: > On Wed, Jan 27, 2016 at 1:49 PM, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> I spoke too soon, I am afraid. >>> ... >>> I wonder if this would be better done as a multi-part series that >>> goes like this: >>> ... >> >> So here is the first of the three-patch ser

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

2016-01-27 Thread Duy Nguyen
On Wed, Jan 27, 2016 at 1:49 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> I spoke too soon, I am afraid. >> ... >> I wonder if this would be better done as a multi-part series that >> goes like this: >> ... > > So here is the first of the three-patch series to replace it. This is much

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

2016-01-26 Thread Junio C Hamano
Junio C Hamano writes: > I spoke too soon, I am afraid. > ... > I wonder if this would be better done as a multi-part series that > goes like this: > ... So here is the first of the three-patch series to replace it. -- >8 -- From: Junio C Hamano Date: Tue, 26 Jan 2016 11:46:53 -0800 Subject: [

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

2016-01-26 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Commit 57ea712 (git.c: make sure we do not leak GIT_* to alias scripts - > 2015-12-20) does not realize that handle_alias() can be called multiple > times because of the forever loop in run_argv(). The commit breaks alias > chains. > > Suppose you have an alias "ab

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

2016-01-26 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > diff --git a/git.c b/git.c > index da278c3..cd733f7 100644 > --- a/git.c > +++ b/git.c > @@ -25,14 +25,15 @@ static const char *env_names[] = { > GIT_PREFIX_ENVIRONMENT > }; > static char *orig_env[4]; > -static int saved_env_before_alias; > +static int sav

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

2016-01-26 Thread Junio C Hamano
Michael J Gruber writes: > Nguyễn Thái Ngọc Duy venit, vidit, dixit 26.01.2016 14:26: >> Commit 57ea712 (git.c: make sure we do not leak GIT_* to alias scripts - >> 2015-12-20) does not realize that handle_alias() can be called multiple >> times because of the forever loop in run_argv(). The comm

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

2016-01-26 Thread Michael J Gruber
Nguyễn Thái Ngọc Duy venit, vidit, dixit 26.01.2016 14:26: > Commit 57ea712 (git.c: make sure we do not leak GIT_* to alias scripts - > 2015-12-20) does not realize that handle_alias() can be called multiple > times because of the forever loop in run_argv(). The commit breaks alias > chains. > > S

[PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

2016-01-26 Thread Nguyễn Thái Ngọc Duy
Commit 57ea712 (git.c: make sure we do not leak GIT_* to alias scripts - 2015-12-20) does not realize that handle_alias() can be called multiple times because of the forever loop in run_argv(). The commit breaks alias chains. Suppose you have an alias "abc" that resolves to another alias "def", wh