Re: [PATCH] git-svn: propset support v2

2014-12-07 Thread Eric Sunshine
On Sat, Dec 6, 2014 at 5:29 PM, Alfred Perlstein wrote: > I have incorporated Eric Wong's feedback into the git-svn propset support > patch. > > There is a nit that I want to point out. The code does not support adding > props > unless there are also content changes to the files as well. You c

[PATCH] git-svn: propset support v2

2014-12-06 Thread Alfred Perlstein
I have incorporated Eric Wong's feedback into the git-svn propset support patch. Issues resolved: 1) Test-case written. 2) Remove dead code. 3) Use shorter vars for formatting. 4) Fix bool comparisons. 5) Check for filesystem errors on write to .gitattribute file. 6) Use command_output_pipe() inst