Re: [PATCH] git-svn: doublecheck if really file or dir

2014-08-03 Thread Eric Wong
Andrej Manduch wrote: > On 08/03/2014 02:22 PM, Andrej Manduch wrote: > > Nice touch, It works like charm. However unfortunatelly now I think you > > introduced new bug :) Good catch! > > On 08/03/2014 04:45 AM, Eric Wong wrote: > >> sub cmd_info { > >> - my $path = canonicalize_path(defined($

Re: [PATCH] git-svn: doublecheck if really file or dir

2014-08-03 Thread Andrej Manduch
On 08/03/2014 02:22 PM, Andrej Manduch wrote: > Hi Eric, > > Nice touch, It works like charm. However unfortunatelly now I think you > introduced new bug :) > > On 08/03/2014 04:45 AM, Eric Wong wrote: >> Hi Andrej, I could not help thinking your patch was obscuring >> another bug. I think I hav

Re: [PATCH] git-svn: doublecheck if really file or dir

2014-08-03 Thread Andrej Manduch
Hi Eric, Nice touch, It works like charm. However unfortunatelly now I think you introduced new bug :) On 08/03/2014 04:45 AM, Eric Wong wrote: > Hi Andrej, I could not help thinking your patch was obscuring > another bug. I think I have an alternative to your patch which > fixes both our bugs.

Re: [PATCH] git-svn: doublecheck if really file or dir

2014-08-02 Thread Eric Wong
Andrej Manduch wrote: > On 07/24/2014 12:04 AM, Eric Wong wrote: > > Andrej Manduch wrote: > >> * this fixes 'git svn info `pwd`' buggy behaviour > > > > While your patch avoids an error, but the output isn't right, either. > > I tried it running in /home/ew/ruby, the URL field is bogus: > Thx,

Re: [PATCH] git-svn: doublecheck if really file or dir

2014-07-26 Thread Andrej Manduch
Hi, On 07/24/2014 12:04 AM, Eric Wong wrote: > Andrej Manduch wrote: >> * this fixes 'git svn info `pwd`' buggy behaviour > > Good catch, the commit could use a better description, something like: > --- 8< > Subject: [PATCH] git-svn: "info" ch

Re: [PATCH] git-svn: doublecheck if really file or dir

2014-07-23 Thread Eric Wong
Andrej Manduch wrote: > * this fixes 'git svn info `pwd`' buggy behaviour Good catch, the commit could use a better description, something like: --- 8< Subject: [PATCH] git-svn: "info" checks for dirs more carefully This avoids a "Reading from

Re: [PATCH] git-svn: doublecheck if really file or dir

2014-07-17 Thread Andrej Manduch
I'm sorry, i've made mistake in this one. Please ingnore it. Correct patch is on the way. kind regards, b. On Fri, Jul 18, 2014 at 6:05 AM, Andrej Manduch wrote: > * this fixes 'git svn info `pwd`' buggy behaviour > > Signed-off-by: Andrej Manduch > --- > git-svn.perl | 2 +- > 1 file changed

[PATCH] git-svn: doublecheck if really file or dir

2014-07-17 Thread Andrej Manduch
* this fixes 'git svn info `pwd`' buggy behaviour Signed-off-by: Andrej Manduch --- git-svn.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-svn.perl b/git-svn.perl index 0a32372..5bbfecf 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -2029,7 +2029,7 @@ sub find_file

[PATCH] git-svn: doublecheck if really file or dir

2014-07-17 Thread Andrej Manduch
* this fixes 'git svn info `pwd`' buggy behaviour Signed-off-by: Andrej Manduch --- git-svn.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-svn.perl b/git-svn.perl index 0a32372..c3d893e 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -2029,7 +2029,7 @@ sub find_file