Eric Wong writes:
> Christopher Layne wrote:
>> * cmd_clone should detect a missing $url arg before using it otherwise
>> an uninitialized value error is emitted in even the simplest case of
>> 'git svn clone' without arguments.
>
> Thanks, this patch looks obviously correct.
>
> I've elimin
> On Jul 2, 2016, at 2315 PT, Eric Wong wrote:
>> sub cmd_clone {
>> my ($url, $path) = @_;
>> -if (!defined $path &&
>> +if (!$url) {
>> +die "SVN repository location required ",
>> +"as a command-line argument\n";
>
> "as a command-line argument" seems
Christopher Layne wrote:
> * cmd_clone should detect a missing $url arg before using it otherwise
> an uninitialized value error is emitted in even the simplest case of
> 'git svn clone' without arguments.
Thanks, this patch looks obviously correct.
I've eliminated the '* ' and space prefix
* cmd_clone should detect a missing $url arg before using it otherwise
an uninitialized value error is emitted in even the simplest case of
'git svn clone' without arguments.
Signed-off-by: Christopher Layne
---
git-svn.perl | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --g
4 matches
Mail list logo
