Re: [PATCH] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-07 Thread Francesco Pretto
2014/1/7 Junio C Hamano : > It is not about preference but what we want to convey to the > readers. When you start the sentence with "Oh, it already works > correctly", the readers need to see this sentence finished: "It > already works, it is handled correctly, but we change the code > neverthele

Re: [PATCH] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-07 Thread Junio C Hamano
Francesco Pretto writes: > Like you said, "it already refers to checkout and handles it > correctly". I think the use of the simple present tense here is > correct: it's a fact. Feel free to advice another wording if you > prefer. It is not about preference but what we want to convey to the read

Re: [PATCH] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-06 Thread Francesco Pretto
2014/1/7 Junio C Hamano : > Sorry, but -ECANNOTPARSE. > A bird told me what -ECANNOTPARSE means. Tell me if this comment sounds better: According to "Documentation/gitmodules.txt", 'checkout' is a valid 'submodule..update' mode. Also "git-submodule.sh" already refers to it and handles it correctl

Re: [PATCH] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-06 Thread Francesco Pretto
2014/1/7 Junio C Hamano : > Francesco Pretto writes: > >> According to "Documentation/gitmodules.txt", 'checkout' is a valid >> 'submodule..update' command. > > As you can see in the surrounding text, we call the value of > submodule.*.update a "mode", not a command. > Ok. >> Also "git-submodule

Re: [PATCH] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-06 Thread Junio C Hamano
Francesco Pretto writes: > According to "Documentation/gitmodules.txt", 'checkout' is a valid > 'submodule..update' command. As you can see in the surrounding text, we call the value of submodule.*.update a "mode", not a command. > Also "git-submodule.sh" refers to > it and processes it correct

[PATCH] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-06 Thread Francesco Pretto
According to "Documentation/gitmodules.txt", 'checkout' is a valid 'submodule..update' command. Also "git-submodule.sh" refers to it and processes it correctly. Reflecting commit 'ac1fbb' to support this syntax and also validate property values during 'update' command, issuing an error if the value