Re: [PATCH] git-sh-setup.sh: use dashdash with basename call

2014-11-24 Thread Junio C Hamano
Dan Wyand writes: > Calling basename on a argument that starts with a dash, like a login shell, > will result in an error. This patch adds '--' before the argument so that the > argument is interpreted properly. > --- Makes sense. Please sign-off your patch (see Documentation/SubmittingPatches)

[PATCH] git-sh-setup.sh: use dashdash with basename call

2014-11-24 Thread Dan Wyand
Calling basename on a argument that starts with a dash, like a login shell, will result in an error. This patch adds '--' before the argument so that the argument is interpreted properly. Signed-off-by: Dan Wyand --- git-sh-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH] git-sh-setup.sh: use dashdash with basename call

2014-11-24 Thread Dan Wyand
Calling basename on a argument that starts with a dash, like a login shell, will result in an error. This patch adds '--' before the argument so that the argument is interpreted properly. --- git-sh-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-sh-setup.sh b/git-