Re: [PATCH] git-send-email: fix handling of special characters

2013-05-23 Thread Michael S. Tsirkin
On Thu, May 23, 2013 at 02:27:59PM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > >> Is $author already sanitized at this point in the code? I see it > >> was unwrapped with unquote_rfc2047 after it was read from the From: > >> line; will it always be the same as sanitize_addres

Re: [PATCH] git-send-email: fix handling of special characters

2013-05-23 Thread Junio C Hamano
"Michael S. Tsirkin" writes: >> Is $author already sanitized at this point in the code? I see it >> was unwrapped with unquote_rfc2047 after it was read from the From: >> line; will it always be the same as sanitize_address($author) would >> return, and if not, would you rather compare between s

Re: [PATCH] git-send-email: fix handling of special characters

2013-05-23 Thread Michael S. Tsirkin
On Thu, May 23, 2013 at 12:52:11PM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > When patch sender's name has special characters, > > git send-email did not quote it before matching > > against the author name. > > As a result it would produce mail like this: > > > > Date:

Re: [PATCH] git-send-email: fix handling of special characters

2013-05-23 Thread Junio C Hamano
Junio C Hamano writes: >> +my $sanitized_sender = sanitize_address($sender); >> +if (defined $author and $author ne $sanitized_sender) { >> $message = "From: $author\n\n$message"; >> if (defined $author_encoding) { >> if ($has_content_type) {

Re: [PATCH] git-send-email: fix handling of special characters

2013-05-23 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > When patch sender's name has special characters, > git send-email did not quote it before matching > against the author name. > As a result it would produce mail like this: > > Date: Thu, 23 May 2013 16:36:00 +0300 > From: "Michael S. Tsirkin" > T

[PATCH] git-send-email: fix handling of special characters

2013-05-23 Thread Michael S. Tsirkin
When patch sender's name has special characters, git send-email did not quote it before matching against the author name. As a result it would produce mail like this: Date: Thu, 23 May 2013 16:36:00 +0300 From: "Michael S. Tsirkin" To: qemu-de...@nongnu.org Cc: "Mi