Re: [PATCH] git-rebase: fix probable reflog typo

2014-04-24 Thread Matthieu Moy
Felipe Contreras writes: > Recently some code was changed to do 'test_must_fail env VAR=VAL command', why > can't we do the same? I guess we can. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to major

Re: [PATCH] git-rebase: fix probable reflog typo

2014-04-24 Thread Felipe Contreras
Matthieu Moy wrote: > Felipe Contreras writes: > > Matthieu Moy wrote: > >> Felipe Contreras writes: > >> > >> > Commit 26cd160 (rebase -i: use a better reflog message) tried to produce > >> > a better reflog message, however, it seems a statement was introduced by > >> > mistake. > >> > > >> >

Re: [PATCH] git-rebase: fix probable reflog typo

2014-04-23 Thread Matthieu Moy
Felipe Contreras writes: > Matthieu Moy wrote: >> Felipe Contreras writes: >> >> > Commit 26cd160 (rebase -i: use a better reflog message) tried to produce >> > a better reflog message, however, it seems a statement was introduced by >> > mistake. >> > >> > 'comment_for_reflog start' basically

Re: [PATCH] git-rebase: fix probable reflog typo

2014-04-23 Thread Felipe Contreras
Matthieu Moy wrote: > Felipe Contreras writes: > > > Commit 26cd160 (rebase -i: use a better reflog message) tried to produce > > a better reflog message, however, it seems a statement was introduced by > > mistake. > > > > 'comment_for_reflog start' basically overides the GIT_REFLOG_ACTION we >

Re: [PATCH] git-rebase: fix probable reflog typo

2014-04-23 Thread Matthieu Moy
Felipe Contreras writes: > Commit 26cd160 (rebase -i: use a better reflog message) tried to produce > a better reflog message, however, it seems a statement was introduced by > mistake. > > 'comment_for_reflog start' basically overides the GIT_REFLOG_ACTION we > just set. I think this is more co

[PATCH] git-rebase: fix probable reflog typo

2014-04-22 Thread Felipe Contreras
Commit 26cd160 (rebase -i: use a better reflog message) tried to produce a better reflog message, however, it seems a statement was introduced by mistake. 'comment_for_reflog start' basically overides the GIT_REFLOG_ACTION we just set. Signed-off-by: Felipe Contreras --- git-rebase--interactive