Re: [PATCH] git-gui.sh: support Tcl 8.4

2015-01-12 Thread Pat Thoyts
Jens Lehmann writes: >Am 07.01.2015 um 01:02 schrieb Junio C Hamano: >> ^"Kyle J. McKay" writes: >>> I can't find anything in that thread about why vsatisfies was >>> preferred over vcompare other than the obvious that the vsatisfies >>> version is only a 1-character change. And that would be m

Re: [PATCH] git-gui.sh: support Tcl 8.4

2015-01-06 Thread Jens Lehmann
Am 07.01.2015 um 01:02 schrieb Junio C Hamano: ^"Kyle J. McKay" writes: I can't find anything in that thread about why vsatisfies was preferred over vcompare other than the obvious that the vsatisfies version is only a 1-character change. And that would be more than enough except that Tcl 8.4

Re: [PATCH] git-gui.sh: support Tcl 8.4

2015-01-06 Thread Junio C Hamano
^"Kyle J. McKay" writes: > greater. But Jens mentions this in $gmane/249491 (that the original > patch was missing the ">= 0" part). Ah, that is what I missed. Thanks. > I can't find anything in that thread about why vsatisfies was > preferred over vcompare other than the obvious that the vsa

Re: [PATCH] git-gui.sh: support Tcl 8.4

2015-01-06 Thread Kyle J. McKay
On Jan 6, 2015, at 11:42, Junio C Hamano wrote: "Kyle J. McKay" writes: Tcl 8.5 introduced an extended vsatisfies syntax that is not supported by Tcl 8.4. Interesting. We discussed this exact thing just before 2.0 in http://thread.gmane.org/gmane.comp.version-control.git/247511/focus=2

Re: [PATCH] git-gui.sh: support Tcl 8.4

2015-01-06 Thread Junio C Hamano
"Kyle J. McKay" writes: > Tcl 8.5 introduced an extended vsatisfies syntax that is not > supported by Tcl 8.4. Interesting. We discussed this exact thing just before 2.0 in http://thread.gmane.org/gmane.comp.version-control.git/247511/focus=248858 and nobody seems to have noticed that giv

[PATCH] git-gui.sh: support Tcl 8.4

2015-01-06 Thread Kyle J. McKay
Tcl 8.5 introduced an extended vsatisfies syntax that is not supported by Tcl 8.4. Since only Tcl 8.4 is required this presents a problem. The extended syntax was used starting with Git 2.0.0 in commit b3f0c5c0 so that a major version change would still satisfy the condition. However, what we re