Re: [PATCH] git-gui: convert new/amend commit radiobutton to checketton

2019-09-13 Thread Bert Wesarg
On Fri, Sep 13, 2019 at 9:49 PM Pratyush Yadav wrote: > > You missed fixing the typo in the subject. s/checketton/checkbutton/. > But no need to send a re-roll for that. I can fix it locally. thanks, I also fixed that locally, but again, it slipped thru in the patch mail. Still don't know why thi

Re: [PATCH] git-gui: convert new/amend commit radiobutton to checketton

2019-09-13 Thread Pratyush Yadav
You missed fixing the typo in the subject. s/checketton/checkbutton/. But no need to send a re-roll for that. I can fix it locally. Other than that, LGTM. Thanks, will queue. On 13/09/19 08:02AM, Bert Wesarg wrote: > Its a bi-state anyway and also saves one line in the menu. > > Signed-off-by:

[PATCH] git-gui: convert new/amend commit radiobutton to checketton

2019-09-12 Thread Bert Wesarg
Its a bi-state anyway and also saves one line in the menu. Signed-off-by: Bert Wesarg --- git-gui.sh | 36 +--- lib/checkout_op.tcl | 6 +++--- lib/commit.tcl | 4 ++-- lib/index.tcl | 8 4 files changed, 18 insertions(+), 36 deleti

Re: [PATCH] git-gui: convert new/amend commit radiobutton to checketton

2019-09-12 Thread Philip Oakley
On 12/09/2019 20:44, Bert Wesarg wrote: Its a bi-state anyway and also safes one line in the menu. s/safes/saves/  ? Signed-off-by: Bert Wesarg --- Philip

[PATCH] git-gui: convert new/amend commit radiobutton to checketton

2019-09-12 Thread Bert Wesarg
Its a bi-state anyway and also safes one line in the menu. Signed-off-by: Bert Wesarg --- git-gui.sh | 36 +--- lib/checkout_op.tcl | 6 +++--- lib/commit.tcl | 4 ++-- lib/index.tcl | 8 4 files changed, 18 insertions(+), 36 deleti