Re: [PATCH] git-gui: Prevent double UTF-8 conversion

2017-12-02 Thread Łukasz Stelmach
On Tue, 28 Nov 2017 15:35:21 +0100, Johannes Schindelin wrote: > On Tue, 28 Nov 2017, Łukasz Stelmach wrote: > > With encoding on the file descriptor set to "binary" Tcl (8.6 in my > > case) does double conversion which breaks e.g. author name in amended > > commits. > > Is the problem in question

Re: [PATCH] git-gui: Prevent double UTF-8 conversion

2017-11-28 Thread Johannes Schindelin
Hi Łukasz, On Tue, 28 Nov 2017, Łukasz Stelmach wrote: > Set encoding to utf-8 for file descriptors used to receive data from git > commands. The patch only changes it for the `cat-file` command used to read the latest commit message for amending. Maybe the commit message should be adjusted to

[PATCH] git-gui: Prevent double UTF-8 conversion

2017-11-28 Thread Łukasz Stelmach
Set encoding to utf-8 for file descriptors used to receive data from git commands. With encoding on the file descriptor set to "binary" Tcl (8.6 in my case) does double conversion which breaks e.g. author name in amended commits. For example "\305\201ukasz" (as written by git cat-file) becomes "\

Re: [PATCH] git-gui: Prevent double UTF-8 conversion

2017-08-21 Thread Stefan Beller
+cc git gui maintainer On Mon, Aug 21, 2017 at 4:53 AM, Łukasz Stelmach wrote: > With encoding on the file descriptor set to "binary" Tcl (8.6 in my case) > does double conversion which breaks e.g. author name in amended commits. > > For example "\305\201ukasz" (as written by git cat-file) become

[PATCH] git-gui: Prevent double UTF-8 conversion

2017-08-21 Thread Łukasz Stelmach
With encoding on the file descriptor set to "binary" Tcl (8.6 in my case) does double conversion which breaks e.g. author name in amended commits. For example "\305\201ukasz" (as written by git cat-file) becomes "\303\205\302\201ukasz". Signed-off-by: Łukasz Stelmach --- git-gui/lib/commit.tcl