Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-03 Thread Pratyush Yadav
On 02/09/19 06:23PM, Philip Oakley wrote: > On 02/09/2019 13:25, Pratyush Yadav wrote: > > On 01/09/19 11:27PM, Philip Oakley wrote: > > > Hi Pratyus, [snip] > > > Are there any plans or thoughts about creating a more inclusive > > > man page for > > > the git-gui? > > Having better documentation

Re: [PATCH] [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-03 Thread Bert Wesarg
On Tue, Sep 3, 2019 at 4:22 PM Pratyush Yadav wrote: > > On 02/09/19 09:42PM, Bert Wesarg wrote: > > On Sun, Sep 1, 2019 at 9:37 PM Birger Skogeng Pedersen > > wrote: > > > > > > The user cannot change focus between the list of files, the diff view and > > > the commit message widgets without usi

Re: [PATCH] [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-03 Thread Pratyush Yadav
On 02/09/19 09:42PM, Bert Wesarg wrote: > On Sun, Sep 1, 2019 at 9:37 PM Birger Skogeng Pedersen > wrote: > > > > The user cannot change focus between the list of files, the diff view and > > the commit message widgets without using the mouse (clicking either of > > the four widgets). > > > > With

Re: [PATCH] [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-03 Thread Birger Skogeng Pedersen
Hi Bert, On Mon, Sep 2, 2019 at 9:42 PM Bert Wesarg wrote: > So we only remember the lno in the widget, that could mean, that we > select the wrong file after a rescan, which shifted the previous path > one down. Can we remember the pathname instead, and try to find this > again in the file list

Re: [PATCH] [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-02 Thread Bert Wesarg
On Sun, Sep 1, 2019 at 9:37 PM Birger Skogeng Pedersen wrote: > > The user cannot change focus between the list of files, the diff view and > the commit message widgets without using the mouse (clicking either of > the four widgets). > > With this patch, the user may set ui focus to the previously

Re: [PATCH] [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-02 Thread Birger Skogeng Pedersen
Ah, sorry I misunderstood you. Thanks, Birger

Re: [PATCH] [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-02 Thread Pratyush Yadav
On 02/09/19 08:35PM, Birger Skogeng Pedersen wrote: > On Mon, Sep 2, 2019 at 8:19 PM Pratyush Yadav wrote: > > You missed removing this extra blank line. Will fix it up locally. > > > > > + set _index $file_lists_last_clicked($widget) > > [snip] > > > To be honest I felt the blank li

Re: [PATCH] [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-02 Thread Birger Skogeng Pedersen
On Mon, Sep 2, 2019 at 8:19 PM Pratyush Yadav wrote: > You missed removing this extra blank line. Will fix it up locally. > > > + set _index $file_lists_last_clicked($widget) > [snip] To be honest I felt the blank line there was appropriate, in an attempt to follow the same code styl

Re: [PATCH] [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-02 Thread Pratyush Yadav
Hi Birger, Other than a minor change that I can do locally, this looks good. I'll test it a bit and then merge it. Thanks. On 01/09/19 09:36PM, Birger Skogeng Pedersen wrote: [snip] > +proc select_path_in {widget} { > + global file_lists last_clicked selected_paths ui_workdir > + global

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-02 Thread Philip Oakley
On 02/09/2019 13:25, Pratyush Yadav wrote: On 01/09/19 11:27PM, Philip Oakley wrote: Hi Pratyus, On 01/09/2019 12:32, Pratyush Yadav wrote: Hi Birger, In case you haven't been following the list, Pat has been inactive recently, so I am acting as the interim maintainer of git-gui for now, becau

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-02 Thread Pratyush Yadav
On 01/09/19 11:27PM, Philip Oakley wrote: > Hi Pratyus, > On 01/09/2019 12:32, Pratyush Yadav wrote: > > Hi Birger, > > > > In case you haven't been following the list, Pat has been inactive > > recently, so I am acting as the interim maintainer of git-gui for now, > > because no one else stepped

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Philip Oakley
Hi Pratyus, On 01/09/2019 12:32, Pratyush Yadav wrote: Hi Birger, In case you haven't been following the list, Pat has been inactive recently, so I am acting as the interim maintainer of git-gui for now, because no one else stepped up and Junio would rather not maintain it. You can find my fork

[PATCH] [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Birger Skogeng Pedersen
The user cannot change focus between the list of files, the diff view and the commit message widgets without using the mouse (clicking either of the four widgets). With this patch, the user may set ui focus to the previously selected path in either the "Unstaged Changes" or "Staged Changes" widget

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Birger Skogeng Pedersen
Hello Bert, > But I don't understand this in full. Does this mean pressing CTRL+1 or > +2 does also changes the file selection? Why isn't it sufficient to > just focus the respective file list widget? And than have bindings to > change the selection? > > Bert I don't think it's feasible to focus

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Bert Wesarg
On Sun, Sep 1, 2019 at 1:32 PM Pratyush Yadav wrote: > > + > > +proc select_first_unstaged_changes_path {} { > > + global ui_workdir > > + select_first_path $ui_workdir > > +} > > + > > +proc select_first_staged_changes_path {} { > > + global ui_index > > + select_first_path $ui_in

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Bert Wesarg
Hi Birger, On Sat, Aug 31, 2019 at 2:23 PM Birger Skogeng Pedersen wrote: > > The user cannot change focus between the list of files, the diff view and > the commit message widgets without using the mouse (clicking either of > the four widgets ). that bugged me two, but never come up with a good

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Birger Skogeng Pedersen
Hello Pratyush, (New patch according to our discussion coming up) On Sun, Sep 1, 2019 at 1:32 PM Pratyush Yadav wrote: > In case you haven't been following the list, Pat has been inactive > recently, so I am acting as the interim maintainer of git-gui for now, > because no one else stepped up

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Junio C Hamano
Pratyush Yadav writes: > ... I am acting as the interim maintainer of git-gui for now, > ... > You can find my fork over at https://github.com/prati0100/git-gui. I am aware of three topics (call-do-quit-before-exit, reload-config and revert-hunks-lines) of your own, plus your 'master' over ther

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Pratyush Yadav
Hi Birger, In case you haven't been following the list, Pat has been inactive recently, so I am acting as the interim maintainer of git-gui for now, because no one else stepped up and Junio would rather not maintain it. You can find my fork over at https://github.com/prati0100/git-gui. I munge

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-08-31 Thread Birger Skogeng Pedersen
(Finally picking this up again) I've been using this feature for about one year now. If I may say so, I think it is actually really great. It's really helpful for me to be able to use git-gui with just the keyboard, and I'm hoping others will find it useful, too. Let me know what you guys think.

[PATCH] git-gui: Add hotkeys to set widget focus

2019-08-31 Thread Birger Skogeng Pedersen
The user cannot change focus between the list of files, the diff view and the commit message widgets without using the mouse (clicking either of the four widgets ). Hotkeys CTRL/CMD+number (1-4) now focuses a previously selected path from either the "Unstaged Changes" or "Staged Changes", the diff