Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-21 Thread Johannes Schindelin
Hi Junio, On Mon, 18 Mar 2019, Junio C Hamano wrote: > Duy Nguyen writes: > > >> - This is synonymous to the previous form. If on > >> + This is synonymous to the previous form. However, > >> + users should prefer the previous form over this form > >> + as this form ma

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-21 Thread Elijah Newren
Hi Denton, On Wed, Mar 20, 2019 at 10:28 AM Denton Liu wrote: > > Hi Elijah, > > Sorry for the late reply, I've been mulling over it for the past couple > of days. No worries; thanks for thinking about it. > On Mon, Mar 18, 2019 at 10:59:56AM -0700, Elijah Newren wrote: > > On Sun, Mar 17, 2019

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-20 Thread Denton Liu
Hi Elijah, Sorry for the late reply, I've been mulling over it for the past couple of days. On Mon, Mar 18, 2019 at 10:59:56AM -0700, Elijah Newren wrote: > Hi Denton, > > Thanks for working on this. Some thoughts... > > On Sun, Mar 17, 2019 at 4:09 AM Denton Liu wrote: > > > > The documentat

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-20 Thread Elijah Newren
On Mon, Mar 18, 2019 at 12:07 PM Ævar Arnfjörð Bjarmason wrote: > On Mon, Mar 18 2019, Elijah Newren wrote: > > > On Sun, Mar 17, 2019 at 6:41 AM Ævar Arnfjörð Bjarmason > > wrote: > >> On Sun, Mar 17 2019, Denton Liu wrote: > >> > Some of this thread's confusing, and on re-reading I see my repl

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-18 Thread Denton Liu
On Mon, Mar 18, 2019 at 03:45:25PM +0900, Junio C Hamano wrote: > Duy Nguyen writes: > > >> - This is synonymous to the previous form. If on > >> + This is synonymous to the previous form. However, > >> + users should prefer the previous form over this form > >> + as th

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-18 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Some of this thread's confusing, and on re-reading I see my reply hasn't > helped much. > > To clarify. There's at least these things to consider: > > 1. What should the semantics of .. or ... be? > 2. What semantics (regardless of syntax) should we recommend for

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-18 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 18 2019, Elijah Newren wrote: > On Sun, Mar 17, 2019 at 6:41 AM Ævar Arnfjörð Bjarmason > wrote: >> On Sun, Mar 17 2019, Denton Liu wrote: >> >> > diff --git a/Documentation/git-diff.txt b/Documentation/git-diff.txt >> > index 72179d993c..10c7a2220c 100644 >> > --- a/Documentation/g

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-18 Thread Elijah Newren
Hi Denton, Thanks for working on this. Some thoughts... On Sun, Mar 17, 2019 at 4:09 AM Denton Liu wrote: > > The documentation used to consider > > git diff > > and > > git diff .. > > to be equal counterparts. However, rev-list-ish commands also use the > .. notation, but in

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-18 Thread Elijah Newren
On Sun, Mar 17, 2019 at 6:41 AM Ævar Arnfjörð Bjarmason wrote: > On Sun, Mar 17 2019, Denton Liu wrote: > > > diff --git a/Documentation/git-diff.txt b/Documentation/git-diff.txt > > index 72179d993c..10c7a2220c 100644 > > --- a/Documentation/git-diff.txt > > +++ b/Documentation/git-diff.txt > > @

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-17 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Sure, and if we're going to change our docs to consistently use @ at > either side of such ranges instead of the empty string for "HEAD" I > think that's worth discussing if the goal is to get rid of ".." for > "diff". > > I'm commenting on the in-between state b

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-17 Thread Junio C Hamano
Duy Nguyen writes: >> - This is synonymous to the previous form. If on >> + This is synonymous to the previous form. However, >> + users should prefer the previous form over this form >> + as this form may be more confusing due to the same >> + notation having a l

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-17 Thread Ævar Arnfjörð Bjarmason
On Sun, Mar 17 2019, Duy Nguyen wrote: > On Sun, Mar 17, 2019 at 8:41 PM Ævar Arnfjörð Bjarmason > wrote: >> >> >> On Sun, Mar 17 2019, Denton Liu wrote: >> >> > The documentation used to consider >> > >> > git diff >> > >> > and >> > >> > git diff .. >> > >> > to be equal counter

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-17 Thread Duy Nguyen
On Sun, Mar 17, 2019 at 8:41 PM Ævar Arnfjörð Bjarmason wrote: > > > On Sun, Mar 17 2019, Denton Liu wrote: > > > The documentation used to consider > > > > git diff > > > > and > > > > git diff .. > > > > to be equal counterparts. However, rev-list-ish commands also use the > > .. n

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-17 Thread Ævar Arnfjörð Bjarmason
On Sun, Mar 17 2019, Denton Liu wrote: > The documentation used to consider > > git diff > > and > > git diff .. > > to be equal counterparts. However, rev-list-ish commands also use the > .. notation, but in a logically conflicting manner which > was confusing for some users (incl

Re: [PATCH] git-diff.txt: prefer not using ..

2019-03-17 Thread Duy Nguyen
On Sun, Mar 17, 2019 at 6:09 PM Denton Liu wrote: > > The documentation used to consider > > git diff > > and > > git diff .. > > to be equal counterparts. However, rev-list-ish commands also use the > .. notation, but in a logically conflicting manner which > was confusing for s

[PATCH] git-diff.txt: prefer not using ..

2019-03-17 Thread Denton Liu
The documentation used to consider git diff and git diff .. to be equal counterparts. However, rev-list-ish commands also use the .. notation, but in a logically conflicting manner which was confusing for some users (including me!). Deprecating the notation entirely is not re