Re: [PATCH] git-completion: add stashes for gitk

2015-03-13 Thread Junio C Hamano
Sveinung Kvilhaugsvik writes: >> A bigger question is why this change is made to gitk completion. If >> this completion were useful for "gitk", wouoldn't it be equally >> useful for "git log"? > I must admit that I didn't know that "git log" could display the > content of a stashed change. After

Re: [PATCH] git-completion: add stashes for gitk

2015-03-13 Thread Sveinung Kvilhaugsvik
Thank you for the review. I now understand that the commit message should have provided way more context about my use case. I used Bazaar almost exclusively until about a year ago. Git's ability to put stuff in the index without committing and the power of "git rebase" covers many of the use case

Re: [PATCH] git-completion: add stashes for gitk

2015-03-12 Thread Junio C Hamano
Junio C Hamano writes: > ... Also, when you have no ref that is named es-tee something, > "gitk st" completes to "gitk stash@{", as if the problem the > change tries to cure is "it is unnecessarily hard to type at-mark > open-brace". > > I do not have to be the target audience, though. Maybe th

Re: [PATCH] git-completion: add stashes for gitk

2015-03-12 Thread Junio C Hamano
Sveinung Kvilhaugsvik writes: > Auto complete stashed modifications for gitk. This makes them easier to > discover and faster to view. > > Signed-off-by: Sveinung Kvilhaugsvik > --- > contrib/completion/git-completion.bash | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/contrib/compl

[PATCH] git-completion: add stashes for gitk

2015-03-11 Thread Sveinung Kvilhaugsvik
Auto complete stashed modifications for gitk. This makes them easier to discover and faster to view. Signed-off-by: Sveinung Kvilhaugsvik --- contrib/completion/git-completion.bash | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/